Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units to meta file #24

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add units to meta file #24

merged 2 commits into from
Aug 12, 2024

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Jul 23, 2024

See DiamondLightSource/ADOdin#22

To test:

  • Run test_file_write
  • Open the created file and confirm that unit attributes are provided on the datasets in the issue

@GDYendell
Copy link
Collaborator

Pin removed now odin-detector/odin-data#351 merged

@GDYendell
Copy link
Collaborator

There are some datasets missing units (e.g. frame time, wavelength), but I guess you have added all the ones you need?

@DominicOram
Copy link
Contributor Author

Yh, I added everything I needed and a few of the more obvious ones. I didn't go through and check every field though, I'm happy to go back and do frame time and wavelength for completeness

@GDYendell
Copy link
Collaborator

I think having just a few of them missing could be confusing, so we should add them all now that you have done most of them.

@DominicOram
Copy link
Contributor Author

Ok, I have added some more, I think that's all of them now. For future reference I used https://media.dectris.com/NeXus_Groups_API_1.3.pdf to work out the units when I was unsure.

@GDYendell GDYendell merged commit 7f2a410 into master Aug 12, 2024
13 checks passed
@GDYendell GDYendell deleted the add_units_to_meta branch August 12, 2024 08:06
@GDYendell GDYendell added this to the 1.16.0 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants