Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Energy Changes: Calculate the bragg angle ourselves #520

Open
DominicOram opened this issue Sep 23, 2024 · 3 comments · May be fixed by #585
Open

Energy Changes: Calculate the bragg angle ourselves #520

DominicOram opened this issue Sep 23, 2024 · 3 comments · May be fixed by #585
Assignees
Labels

Comments

@DominicOram
Copy link
Contributor

From #277 we found that the bragg angle on the DCM BL03I-MO-DCM-01:BRAGG does not update quickly after we set BL03I-MO-DCM-01:ENERGY. We need the bragg angle for lookup tables on movements that we should be able to do at the same time as the energy change and so we will need to work out what the bragg angle is ourselves.

This can be calculated by substituting the d-spacing of Si into bragg's law.

Acceptance Criteria

  • We calculate the bragg angle of the DCM early when changing energy
  • We move the other motors we have to move at the same time as the DCM energy motor
@DominicOram
Copy link
Contributor Author

We can read the d-spacing of the DC from BL03I-MO-DCM-01:DSPACING:RBV

@DominicOram
Copy link
Contributor Author

The metadata from DiamondLightSource/dodal#722 might also be helpful

@rtuck99
Copy link
Contributor

rtuck99 commented Oct 18, 2024

Paused waiting on DiamondLightSource/dodal#843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Blocked
2 participants