Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up parameter version #461

Open
DominicOram opened this issue Sep 9, 2024 · 0 comments · May be fixed by #583
Open

Tidy up parameter version #461

DominicOram opened this issue Sep 9, 2024 · 0 comments · May be fixed by #583
Assignees
@DominicOram
Labels
hyperion

Comments

@DominicOram
Copy link
Contributor

Following comments on #456 (review). Rather than use our own ParameterVersion class we should be able to make use of pydantic/pydantic-extra-types#199.

Acceptance Criteria

  • Bespoke code for ParameterVersion is removed
  • Functionality remains unchanged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DominicOram DominicOram

Labels
hyperion
Projects
Hyperion
Status: Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use in-built type for parameter version DiamondLightSource/mx-bluesky
1 participant
@DominicOram