Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy scripts #531

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Fix deploy scripts #531

merged 7 commits into from
Sep 27, 2024

Conversation

noemifrisina
Copy link
Contributor

@noemifrisina noemifrisina commented Sep 26, 2024

  • wrong/broken paths
  • repo name
  • updates docs

In the future there should be only one, see #532

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (9c1e4b1) to head (d1ee612).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #531   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files          89       89           
  Lines        6711     6711           
=======================================
  Hits         5228     5228           
  Misses       1483     1483           
Components Coverage Δ
i24 SSX 57.12% <ø> (ø)
hyperion 96.25% <ø> (ø)
other 94.79% <ø> (ø)


and a released version will be put in ``/scratch/30day_tmp/hyperion_release_test``.

For building and deploying a Docker image please see :doc:`../../hyperion/deploying-hyperion`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a note for deploying on i03:

post-installation step:
On i03 installation will succeed with error messages due to RedHat 7 versions of a dependency being unavailable. However the installation will be incomplete.

To fix this, on a RH 8 workstation

. ./.venv/bin/activate
pip install confluent-kafka

Then on the control machine

. ./.venv/bin/activate
pip install -e.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then

pip install -e ../dodal

@@ -141,7 +141,7 @@ def _create_environment_from_control_machine(

def main(options: Options):
release_area = options.release_dir
this_repo_top = os.path.abspath(os.path.join(os.path.dirname(__file__), "../.."))
this_repo_top = os.path.abspath(os.path.join(os.path.dirname(__file__), "../../.."))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we actually need this change - ../.. will be the project directory which contains the .git folder, mx-bluesky needs it because it was ../.git rather than ../../.git
I think I only ran into this issue bc I initially ran the wrong script

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved subject to suggested changes

@noemifrisina
Copy link
Contributor Author

Done

@noemifrisina noemifrisina merged commit cbfe74b into main Sep 27, 2024
21 checks passed
@noemifrisina noemifrisina deleted the fix-deploy-script branch September 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants