-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deploy scripts #531
Fix deploy scripts #531
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
=======================================
Coverage 77.90% 77.90%
=======================================
Files 89 89
Lines 6711 6711
=======================================
Hits 5228 5228
Misses 1483 1483
|
|
||
and a released version will be put in ``/scratch/30day_tmp/hyperion_release_test``. | ||
|
||
For building and deploying a Docker image please see :doc:`../../hyperion/deploying-hyperion`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a note for deploying on i03:
post-installation step:
On i03 installation will succeed with error messages due to RedHat 7 versions of a dependency being unavailable. However the installation will be incomplete.
To fix this, on a RH 8 workstation
. ./.venv/bin/activate
pip install confluent-kafka
Then on the control machine
. ./.venv/bin/activate
pip install -e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then
pip install -e ../dodal
@@ -141,7 +141,7 @@ def _create_environment_from_control_machine( | |||
|
|||
def main(options: Options): | |||
release_area = options.release_dir | |||
this_repo_top = os.path.abspath(os.path.join(os.path.dirname(__file__), "../..")) | |||
this_repo_top = os.path.abspath(os.path.join(os.path.dirname(__file__), "../../..")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we actually need this change - ../..
will be the project directory which contains the .git folder, mx-bluesky needs it because it was ../.git
rather than ../../.git
I think I only ran into this issue bc I initially ran the wrong script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to suggested changes
Done |
In the future there should be only one, see #532