-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deploy scripts #531
Merged
Merged
Fix deploy scripts #531
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d175655
Fix deploy script
noemifrisina 0154142
Fix path for hyperion too
noemifrisina e5d86a6
Fix some names
noemifrisina 42f622f
Update docs
noemifrisina 1945bd6
add i04
noemifrisina c7aa279
address comments
noemifrisina d1ee612
Merge branch 'main' into fix-deploy-script
noemifrisina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,63 @@ | ||
Deploy a New Release | ||
----------------------- | ||
==================== | ||
|
||
**Remember to discuss any new deployments with the appropriate beamline scientist.** | ||
|
||
The ``/deploy/deploy_mxbluesky.py`` script will deploy the latest Hyperion version to a specified beamline. Deployments live in ``/dls_sw/ixx/software/bluesky/mx-bluesky_vXXX``. To do a new deployment you should run the deploy script from your mx-bluesky dev environment with e.g. | ||
|
||
``python ./deploy/deploy_mxbluesky.py --beamline i24`` | ||
General deployment | ||
-------------------- | ||
|
||
The ``utility_scripts/deploy/deploy_mxbluesky.py`` script will deploy the latest mx-bluesky version to a specified beamline. Deployments live in ``/dls_sw/ixx/software/bluesky/mx-bluesky_vX.X.X``. To do a new deployment you should run the deploy script from your mx-bluesky dev environment with e.g. | ||
|
||
.. code:: console | ||
|
||
python ./utility_scripts/deploy/deploy_mxbluesky.py --beamline i24 | ||
|
||
|
||
If you want to test the script you can run: | ||
|
||
``python ./deploy/deploy_mxbluesky.py --dev-path /your-path/`` | ||
.. code:: console | ||
|
||
python ./deploy/deploy_mxbluesky.py --dev-path /your-path/ | ||
|
||
and a released version will be put in ``/your-path/mxbluesky_release_test``. | ||
|
||
If you need a specific beamline test deployment you can also run: | ||
|
||
``python ./deploy/deploy_mxbluesky.py --beamline i24 --dev-path /your-path/`` | ||
|
||
.. code:: console | ||
|
||
python ./deploy/deploy_mxbluesky.py --beamline i24 --dev-path /your-path/ | ||
|
||
which will create the beamline deployment (eg. I24) in the specified test directory ``/your-path/mxbluesky_release_test``. | ||
|
||
|
||
**Note:** When deploying on I24, the edm screens for serial crystallography will be deployed automatically along with the mx-bluesky release. | ||
When running a ``dev`` deployment instead, `this script <https://github.com/DiamondLightSource/mx-bluesky/wiki/Serial-Crystallography-on-I24#deploying-a-local-version-of-the-edm-screens>`_ will also need to be run to get the latest version of the screens. | ||
|
||
|
||
Hyperion deployment | ||
------------------- | ||
|
||
The ``utility_scripts/deploy/deploy_hyperion.py`` script will deploy the latest mx-bluesky/Hyperion version to a specified beamline. Deployments live in ``/dls_sw/ixx/software/bluesky/mx-bluesky_vX.X.X``. | ||
|
||
If you have just created a release as above, you may need to run git fetch --tags to get the newest release. | ||
|
||
To do a new deployment you should run the deploy script from your Hyperion dev environment with e.g. | ||
|
||
.. code:: console | ||
|
||
python ./utility_scripts/deploy/deploy_hyperion.py i03 | ||
|
||
|
||
If you want to test the script you can run: | ||
|
||
|
||
.. code:: console | ||
|
||
python ./utility_scripts/deploy/deploy_hyperion.py dev | ||
|
||
|
||
and a released version will be put in ``/scratch/30day_tmp/hyperion_release_test``. | ||
|
||
For building and deploying a Docker image please see :doc:`../../hyperion/deploying-hyperion`. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,7 +141,7 @@ def _create_environment_from_control_machine( | |
|
||
def main(options: Options): | ||
release_area = options.release_dir | ||
this_repo_top = os.path.abspath(os.path.join(os.path.dirname(__file__), "../..")) | ||
this_repo_top = os.path.abspath(os.path.join(os.path.dirname(__file__), "../../..")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we actually need this change - |
||
|
||
if not options.quiet: | ||
print(f"Repo top is {this_repo_top}") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a note for deploying on i03:
post-installation step:
On i03 installation will succeed with error messages due to RedHat 7 versions of a dependency being unavailable. However the installation will be incomplete.
To fix this, on a RH 8 workstation
Then on the control machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then