Merge deployment scripts into one #548
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
=======================================
Coverage 78.12% 78.12%
=======================================
Files 93 93
Lines 6799 6799
=======================================
Hits 5312 5312
Misses 1487 1487
|
noemifrisina
requested review from
rtuck99,
DominicOram,
dperl-dls and
olliesilvester
| with Popen( | ||
| path_to_create_venv_script, stdout=PIPE, bufsize=1, universal_newlines=True | ||
| ) as p: | ||
| def run_process_and_print_output(proc_to_run): |
There was a problem hiding this comment.
We should probably capture stderr here as well and print it
| "-nc", | ||
| "--no-control", | ||
| action="store_false", | ||
| help="Create environment from the control machine.", |
There was a problem hiding this comment.
This is confusingly worded! Can it be changed to something like "If running from the control machine use this to create the venv directly and not via ssh"
| ) | ||
|
|
||
| if hyperion_repo.name != "hyperion": | ||
| raise ValueError("This function should only be used with the hyperion repo") | ||
| if mx_repo.name != "mx-bluesky": |
There was a problem hiding this comment.
why would the repo name ever not be mx-bluesky given we just constructed it?
| # If on beamline I24 also deploy the screens to run ssx collections | ||
| if beamline == "i24": | ||
| print("Setting up edm screens for serial collections on I24.") | ||
| run_process_and_print_output("./utility_scripts/deploy/deploy_edm_for_ssx.sh") | ||
|
|
There was a problem hiding this comment.
Can this be a top-level function please
|
I was going to add lots of comments about the documentation but instead I raised a separate GH issue #578 |
|
|
||
| which will create the beamline deployment (eg. I24) in the specified test directory ``/your-path/mxbluesky_release_test``. | ||
|
|
||
| python ./deploy/deploy_mx_bluesky.py i03 --dev |
There was a problem hiding this comment.
utility_scripts/deploy/deploy_mx_bluesky.py
|
|
||
| which will create the beamline deployment of the new release in ``/scratch/30day_tmp/mxbluesky_release_test``. |
One script to deploy them all. Closes #532
To test: