Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we enable dev/shm when required #555

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DominicOram
Copy link
Contributor

Fixes #545

See also DiamondLightSource/dodal#819

To test:

  • Confirm test fails on main and passes here

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.18%. Comparing base (4636129) to head (d801dfb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   78.19%   78.18%   -0.01%     
==========================================
  Files          92       92              
  Lines        6796     6794       -2     
==========================================
- Hits         5314     5312       -2     
  Misses       1482     1482              
Components Coverage Δ
i24 SSX 57.12% <ø> (ø)
hyperion 96.23% <100.00%> (-0.01%) ⬇️
other 100.00% <ø> (ø)

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that, right now, we only ever use the gpu results for comparison (rather than actually use them for analysis), I think we should just remove use_cpu_and_gpu_zocalo - we can use use_gpu for this too.

Also would be good to add a comment saying that use_gpu=True means dev/shm is enabled and that a comparison is made between CPU and GPU results

@DominicOram
Copy link
Contributor Author

As discussed, naming is confusing, we should removeuse_gpu for now and rename use_cpu_and_gpu_zocalo to compare_cpu_and_gpu_results then only turn dev/shm on when compare_cpu_and_gpu_results is True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperion testing 01/10
2 participants