Update from beamline test 14102024 #571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
noemifrisina
commented
Oct 15, 2024
noemifrisina
commented
- Update the cs_maker.json scale factors for the coordinate system after recalibration
- Fix y direction in moveonclick (again) and test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
=======================================
Coverage 78.21% 78.21%
=======================================
Files 92 92
Lines 6797 6797
=======================================
Hits 5316 5316
Misses 1481 1481
|
DominicOram
approved these changes
Oct 17, 2024
| ymove = -1 * (beamY - y) * zoomcalibrator | ||
| ymove = 1 * (beamY - y) * zoomcalibrator |
There was a problem hiding this comment.
As discussed, the theory is that this may be due to the rotation of the grid. Could you make an issue to investigate the reasoning behind this and find a way to fix it permanently please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.