Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up i24 serial logs #572

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Tidy up i24 serial logs #572

wants to merge 15 commits into from

Conversation

noemifrisina
Copy link
Contributor

@noemifrisina noemifrisina commented Oct 15, 2024

  • Set level of stream handler to INFO
  • Only integrate bluesky and ophyd_async loggers, as no ophyd devices are used for serial anymore
  • Do not import all handlers from dodal

Closes #557

@noemifrisina noemifrisina added the I24 serial Issues relating to ssx on I24 label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.22%. Comparing base (0ff840f) to head (7e448ee).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   78.21%   78.22%   +0.01%     
==========================================
  Files          92       92              
  Lines        6797     6801       +4     
==========================================
+ Hits         5316     5320       +4     
  Misses       1481     1481              
Components Coverage Δ
i24 SSX 57.22% <100.00%> (+0.05%) ⬆️
hyperion 96.23% <ø> (ø)
other 100.00% <ø> (ø)

@noemifrisina noemifrisina marked this pull request as ready for review October 15, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I24 serial Issues relating to ssx on I24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I24 ssx: tidy up log configuration
1 participant