Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Crystal library #357

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Conversation

iamvigneshwars
Copy link
Collaborator

@iamvigneshwars iamvigneshwars commented Feb 15, 2024

Tables:
crystal_wells
plate_id : Uuid,
well_num : i16.
operator_id: String,
timestamp: DateTime,

queries :
crystal, crystals

mutations:
add_crystal

@iamvigneshwars iamvigneshwars added enhancement New feature or request rust Pull requests that update Rust code labels Feb 15, 2024
@garryod garryod self-requested a review February 15, 2024 11:44
@iamvigneshwars iamvigneshwars marked this pull request as draft February 19, 2024 14:07
@iamvigneshwars iamvigneshwars marked this pull request as ready for review February 20, 2024 15:20
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Would it be worth tracking plates separately as they're the unit that XChem staff / users work with and is probably what AuthZ should be performed on?

backend/crystal_library/src/entities/crystal_wells.rs Outdated Show resolved Hide resolved
backend/crystal_library/src/graphql/crystal_wells_res.rs Outdated Show resolved Hide resolved
backend/crystal_library/src/entities/crystal_wells.rs Outdated Show resolved Hide resolved
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

backend/crystal_library/src/graphql/crystal_wells_res.rs Outdated Show resolved Hide resolved
backend/crystal_library/src/entities/mod.rs Outdated Show resolved Hide resolved
backend/crystal_library/src/graphql/mod.rs Outdated Show resolved Hide resolved
@garryod garryod merged commit 27e3347 into DiamondLightSource:main Feb 27, 2024
21 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants