This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Federated compound soaking service #375
Merged
iamvigneshwars
merged 7 commits into
DiamondLightSource:main
from
iamvigneshwars:federated_graph
Mar 5, 2024
Merged
Federated compound soaking service #375
iamvigneshwars
merged 7 commits into
DiamondLightSource:main
from
iamvigneshwars:federated_graph
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamvigneshwars
added
enhancement
New feature or request
rust
Pull requests that update Rust code
labels
Feb 27, 2024
iamvigneshwars
force-pushed
the
federated_graph
branch
2 times, most recently
from
February 27, 2024 12:23
3ca6841
to
74db057
Compare
iamvigneshwars
force-pushed
the
federated_graph
branch
from
February 27, 2024 12:44
74db057
to
78deea6
Compare
garryod
suggested changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, and fairly simple too!
Any chance you could add an instance of the apollo router to the devcontainer docker-compose
? If we need stuff to run on different ports perhaps it would be worth setting them in the environment variables of the backend dev container
iamvigneshwars
force-pushed
the
federated_graph
branch
from
February 29, 2024 13:10
f1e7713
to
326181d
Compare
garryod
suggested changes
Feb 29, 2024
iamvigneshwars
force-pushed
the
federated_graph
branch
5 times, most recently
from
February 29, 2024 16:33
f5eaffe
to
0dfc7af
Compare
garryod
suggested changes
Feb 29, 2024
iamvigneshwars
force-pushed
the
federated_graph
branch
2 times, most recently
from
February 29, 2024 16:54
95198ea
to
7b914c3
Compare
garryod
suggested changes
Feb 29, 2024
iamvigneshwars
force-pushed
the
federated_graph
branch
from
February 29, 2024 17:16
7b914c3
to
e981500
Compare
garryod
approved these changes
Mar 5, 2024
iamvigneshwars
merged commit Mar 5, 2024
72929c7
into
DiamondLightSource:main
20 of 22 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crystal entry point
Compound entry point