Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with newer infos #1144

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Update README with newer infos #1144

merged 1 commit into from
Jul 6, 2024

Conversation

getzze
Copy link
Collaborator

@getzze getzze commented Jul 4, 2024

Update badges and installation method.

Copy link

github-actions bot commented Jul 4, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Collaborator

@ptrcnull ptrcnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two little things:

  • discord badge: [![Discord](https://img.shields.io/discord/1256603445411184740?style=for-the-badge&label&logo=discord&logoColor=white&color=blue)](https://discord.gg/kXW6sWte9N) ( @Diaoul, I generated a new invite code because yours was limited to 1 year; probably not a problem, but we can make an unlimited one so why not )
  • maybe we should make the towncrier snippets capitalized?

@getzze getzze force-pushed the update-readme branch 2 times, most recently from b3a62d6 to a3a1770 Compare July 4, 2024 22:51
@getzze
Copy link
Collaborator Author

getzze commented Jul 4, 2024

FIY, the url of the discord badge gives an Invalid badge.

@ptrcnull
Copy link
Collaborator

ptrcnull commented Jul 4, 2024

ah, edited with the correct URL

@getzze
Copy link
Collaborator Author

getzze commented Jul 4, 2024

  • maybe we should make the towncrier snippets capitalized?

Maybe this can be enforced at build time.

@getzze getzze requested a review from ptrcnull July 5, 2024 14:54
@getzze getzze merged commit 5ff3994 into Diaoul:main Jul 6, 2024
20 checks passed
@getzze getzze deleted the update-readme branch July 6, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants