Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI and config file options to ignore refiner, provider and subtitle ids #1160

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

getzze
Copy link
Collaborator

@getzze getzze commented Jul 25, 2024

fixes #585, #752, #1018

This PR adds some CLI options:

  • --ignore-refiner: can be repeated, refiner to ignore.
  • --ignore-provider: can be repeated, provider to ignore.
  • --extend-refiner: can be repeated, refiner to extend to the list of refiners to use.
  • --extend-provider: can be repeated, provider to extend to the list of providers to use.
  • --ignore-subtitles: can be repeated, subtitle id to ignore.

These can also be defined in the configuration file, so it's important to make sure the CLI options always takes precedence over the config file. This logic is implemented (and tested) in merge_extend_and_ignore_unions.

(I followed the naming of ruff, select-extend-ignore :))

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  subliminal
  core.py 323, 651-657
  extensions.py
  utils.py
Project Total  

This report was generated by python-coverage-comment-action

@getzze getzze requested a review from ptrcnull July 26, 2024 22:05
@getzze getzze mentioned this pull request Jul 26, 2024
18 tasks
@getzze getzze merged commit dcbae82 into Diaoul:main Sep 9, 2024
18 of 20 checks passed
@getzze getzze deleted the ignore-things branch November 25, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to skip hash as identification method
1 participant