ft: Add support for PFDEBUG command #1216
Conversation
internal/eval/eval.go
Outdated
| } | ||
|
|
||
| sparseField := reflect.ValueOf(hll).Elem().FieldByName("sparseList") | ||
| sparseFieldValue := reflect.NewAt(sparseField.Type(), unsafe.Pointer(sparseField.UnsafeAddr())).Elem() |
There was a problem hiding this comment.
Is there a way we can avoid usage of unsafe pointers?
There was a problem hiding this comment.
one thing we can do, convert the hyperloglog structure to binary, the third byte is 0/1 depending on sparse/dense notation. I'll use that instead.
internal/eval/eval.go
Outdated
|
|
||
| obj := store.Get(key) | ||
| if obj == nil { | ||
| return diceerrors.NewErrWithMessage("Key does not exist") |
There was a problem hiding this comment.
This should match the message returned by redis, and ideally be defined as a constant string in the constants file.
There was a problem hiding this comment.
yeah, matches the message. Will define as constant
internal/eval/eval.go
Outdated
| } | ||
|
|
||
| switch subcommand { | ||
| case "GETREG": |
There was a problem hiding this comment.
Use a constant to define this string in the constants file. Same for other cases.
internal/eval/eval.go
Outdated
| // For call to GETREG, encoding is converted from sparse to dense. | ||
| // We'll merge a sparse and an empty dense HLL to get a dense HLL | ||
| // with values of sparse HLL. | ||
| if encoding == "sparse" { |
There was a problem hiding this comment.
Define this string in a constant. It would also be good to be consistent with the casing of these constants.
…upport-for-hll-debug-commands
|
Hi @neverwannafly , Thanks for addressing the comments. Could you please rebase the PR and re-request for review? Thanks |
Description
This PR adds support for
PFDEBUGcommand in dicedb.Progress