Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use template strings #2

Open
brion25 opened this issue Oct 23, 2018 · 0 comments
Open

Use template strings #2

brion25 opened this issue Oct 23, 2018 · 0 comments

Comments

@brion25
Copy link

brion25 commented Oct 23, 2018

RepoSearchEngine/src/app/comments.service.ts

Lines 11 to 18 in 9156dc7

getComments(name: string, owner: string) {
return this.http
.get(
"https://api.github.com/repos/" +
owner +
"/" +
name +
"/issues/5/comments"

should be:

return this.http 
     .get(`https://api.github.com/repos/${owner}/${name}/issues/5/comments`)
Diegorandom pushed a commit that referenced this issue Oct 23, 2018
@DiegOrtega
fix de issue #2
65840ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brion25