-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chat text decoration #3
base: main
Are you sure you want to change the base?
Conversation
@@ -26,7 +26,6 @@ dependencies { | |||
modImplementation("net.silkmc:silk-commands:$silkVersion") | |||
|
|||
include(implementation("me.obsilabor", "alert", "1.0.8")) | |||
include(implementation("org.jetbrains.kotlinx", "kotlinx-serialization-json", "1.7.0")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, consider using one format of dependency notations and not multiple across the buildscript
|
||
@Inject(at = @At("RETURN"), method = "decoratedContent", cancellable = true) | ||
private void injectDecoratedContent(CallbackInfoReturnable<Component> cir) { | ||
live.einfachgustaf.mods.smp.mixinkt.MixinPlayerChatMessage.INSTANCE.injectDecoratedContent(cir); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider importing the class
import net.minecraft.network.chat.Component | ||
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable | ||
|
||
object MixinPlayerChatMessage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid duplicate class names please
@@ -26,7 +26,6 @@ dependencies { | |||
modImplementation("net.silkmc:silk-commands:$silkVersion") | |||
|
|||
include(implementation("me.obsilabor", "alert", "1.0.8")) | |||
include(implementation("org.jetbrains.kotlinx", "kotlinx-serialization-json", "1.7.0")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, consider using one format of dependency notations and not multiple across the buildscript
I would consider marking this as a draft. |
No description provided.