Status Feature #4
Conversation
| @@ -6,6 +6,6 @@ | |||
| "defaultRequire": 0 | |||
| }, | |||
| "mixins": [ | |||
|
|
|||
| "feature.status.MixinServerPlayer" | |||
There was a problem hiding this comment.
Please don't register server side mixins on the common side
| import java.io.File | ||
|
|
||
| val json = Json { | ||
| prettyPrint = true |
There was a problem hiding this comment.
you may want to add isLenient = true
| serverPlayer: ServerPlayer, | ||
| cir: CallbackInfoReturnable<Component> | ||
| ) { | ||
| logger.info("LOL CALLED") |
There was a problem hiding this comment.
Either make it a logger.debug() or remove it
| requiresPermissionLevel(2) //TODO: Optional LuckPerms Implementation | ||
| argument<String>("status") { statusArgument -> | ||
| suggestList { | ||
| statusList.filter { !it.name.contains(" ") }.map { it.name } |
There was a problem hiding this comment.
Why? Just set the argument to StringArgumentType.greedyString() in order to deal with spaces
| runs { | ||
| if (!statusList.map { it.name }.contains(statusArgument())) return@runs | ||
| playerStatusMap[source.playerOrException] = statusList.first { it.name == statusArgument() } | ||
| source.sendSystemMessage(Component.literal("Your status is now '${statusArgument()}'.")) // TODO: translateable |
There was a problem hiding this comment.
Please consider using the same component builder in all places.
| } | ||
|
|
||
| @Serializable | ||
| data class Status( |
There was a problem hiding this comment.
This could be a HashMap instead.
|
would be better to mark the PR as a draft |
@mathearbeit76 yeah, thank you for your review, I have new ideas for a status system so I am going to recode that, |
No description provided.