Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guides improvements #2

Merged
merged 5 commits into from
Sep 15, 2024
Merged

Guides improvements #2

merged 5 commits into from
Sep 15, 2024

Conversation

Turolatias
Copy link
Contributor

I added mentions to the message content intent, which is necessary to make some projects in the guides work

@CompeyDev CompeyDev added the documentation Improvements or additions to documentation label Sep 15, 2024
@CompeyDev CompeyDev self-assigned this Sep 15, 2024
Copy link
Member

@CompeyDev CompeyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(something I noticed here was the use of addEmbed as opposed to setEmbed, is this how it's supposed to be used (cc @4x8Matrix)?)

Everything else looks fine other than the small spelling mistake, can merge once fixed.

src/content/docs/guides/attachments.mdx Outdated Show resolved Hide resolved
@4x8Matrix
Copy link
Member

Yes, we are supposed to use the addEmbed method, not setEmbed @CompeyDev ! 😅

Co-authored-by: Erica Marigold <hi@devcomp.xyz>
Copy link
Member

@CompeyDev CompeyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CompeyDev CompeyDev merged commit 897aa1a into DiscordLuau:master Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants