Adding USB Support for dive computers #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sese-Schneider
force-pushed
the
develop
branch
from
e284550
to
385bd8d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
…into usb-support
Sese-Schneider
requested changes
Feb 15, 2024
| PUBLIC_HEADER dive_computer.h | ||
| OUTPUT_NAME "dive_computer" | ||
| OUTPUT_NAME "libdivecomputer" |
There was a problem hiding this comment.
Why does the output name need to be libdivecomputer?
Comment on lines
+52
to
+54
| # add_compile_definitions(__APPLE__=1) | ||
| # add_compile_definitions(HAVE_HIDAPI=1) | ||
| # add_compile_definitions(HAVE_PTHREAD_H=1) |
|
@Sese-Schneider I think we should discuss if this PR can be merged or how changes should look like. Shall we have a call? |
|
@Ben1980 PR looks very good so far - I want to test it myself after the weekend and merge it ASAP. |
|
merging to develop - windows is still not working so this would be my next step to get it to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides USB and USB HID support for macOS.
All dependencies come via git submodules and are built during example compilation time.
Logging is also now working but needs a review.
I was only able to confirm USB HID working with Suunto EON Core, can't say if USB is working but I guess it is.