Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the errors when incrementing the counter value #1003

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Fix the errors when incrementing the counter value #1003

merged 2 commits into from
Jul 20, 2023

Commits on Jul 12, 2023

  1. Fix the errors when incrementing the counter value 

    - the name of the action in the CounterController should be :count instead of :home
- when passing a value via query parameters, it fails to be updated because the type of the @counter is of type String
- add the helper method to the CounterHTML component to convert the String to Integer
    @belgoros
    belgoros committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c48bcda View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Fix code review remarks 

    - remove to_number/1 (fixed in the controller, see demos/counter)
- remove the call to to_number/1 in the count.html.heex template
    @belgoros
    belgoros committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    e74b95f View commit details
    Browse the repository at this point in the history