diff --git a/build/phpstan/phpstan-baseline.neon b/build/phpstan/phpstan-baseline.neon index e198622d68597..98753b00b965e 100644 --- a/build/phpstan/phpstan-baseline.neon +++ b/build/phpstan/phpstan-baseline.neon @@ -2622,12 +2622,6 @@ parameters: count: 1 path: ../../htdocs/asset/class/asset.class.php - - - message: '#^Property Asset\:\:\$fields \(array\\|string, position\: int, notnull\?\: int, visible\: int\<\-2, 5\>\|string, noteditable\?\: int\<0, 1\>, default\?\: string, \.\.\.\}\>\) does not accept non\-empty\-array\\|string, position\: int, notnull\?\: int, visible\: int\<\-2, 5\>\|string, noteditable\?\: ''1''\|int\<0, 1\>, default\?\: string, \.\.\.\}\>\.$#' - identifier: assign.propertyType - count: 6 - path: ../../htdocs/asset/class/asset.class.php - - message: '#^Property Asset\:\:\$status \(int\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -4062,12 +4056,6 @@ parameters: count: 2 path: ../../htdocs/comm/action/class/actioncomm.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 1 - path: ../../htdocs/comm/action/class/actioncomm.class.php - - message: '#^Right side of && is always true\.$#' identifier: booleanAnd.rightAlwaysTrue @@ -4824,24 +4812,6 @@ parameters: count: 2 path: ../../htdocs/comm/propal/class/propal.class.php - - - message: '#^Property CommonObject\:\:\$note \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 1 - path: ../../htdocs/comm/propal/class/propal.class.php - - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 3 - path: ../../htdocs/comm/propal/class/propal.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/comm/propal/class/propal.class.php - - message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -4920,12 +4890,6 @@ parameters: count: 1 path: ../../htdocs/comm/propal/class/propal.class.php - - - message: '#^Result of \|\| is always true\.$#' - identifier: booleanOr.alwaysTrue - count: 1 - path: ../../htdocs/comm/propal/class/propal.class.php - - message: '#^Right side of && is always true\.$#' identifier: booleanAnd.rightAlwaysTrue @@ -5268,24 +5232,6 @@ parameters: count: 2 path: ../../htdocs/commande/class/commande.class.php - - - message: '#^Property CommonObject\:\:\$note \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 1 - path: ../../htdocs/commande/class/commande.class.php - - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 3 - path: ../../htdocs/commande/class/commande.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/commande/class/commande.class.php - - message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -5334,12 +5280,6 @@ parameters: count: 1 path: ../../htdocs/commande/class/commande.class.php - - - message: '#^Result of \|\| is always true\.$#' - identifier: booleanOr.alwaysTrue - count: 1 - path: ../../htdocs/commande/class/commande.class.php - - message: '#^Right side of && is always true\.$#' identifier: booleanAnd.rightAlwaysTrue @@ -6552,24 +6492,6 @@ parameters: count: 3 path: ../../htdocs/compta/facture/class/facture.class.php - - - message: '#^Property CommonObject\:\:\$note \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 4 - path: ../../htdocs/compta/facture/class/facture.class.php - - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 5 - path: ../../htdocs/compta/facture/class/facture.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 3 - path: ../../htdocs/compta/facture/class/facture.class.php - - message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -6654,12 +6576,6 @@ parameters: count: 3 path: ../../htdocs/compta/facture/class/facture.class.php - - - message: '#^Result of \|\| is always true\.$#' - identifier: booleanOr.alwaysTrue - count: 2 - path: ../../htdocs/compta/facture/class/facture.class.php - - message: '#^Variable \$newlang in empty\(\) always exists and is always falsy\.$#' identifier: empty.variable @@ -7842,18 +7758,6 @@ parameters: count: 1 path: ../../htdocs/compta/sociales/class/chargesociales.class.php - - - message: '#^Property CommonObject\:\:\$note \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 1 - path: ../../htdocs/compta/sociales/class/paymentsocialcontribution.class.php - - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/compta/sociales/class/paymentsocialcontribution.class.php - - message: '#^Property PaymentSocialContribution\:\:\$amount \(float\|int\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -8250,12 +8154,6 @@ parameters: count: 4 path: ../../htdocs/compta/tva/card.php - - - message: '#^Property CommonObject\:\:\$note \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 3 - path: ../../htdocs/compta/tva/class/paymentvat.class.php - - message: '#^Property PaymentVAT\:\:\$amount \(float\|int\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -8706,18 +8604,6 @@ parameters: count: 2 path: ../../htdocs/contact/class/contact.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 1 - path: ../../htdocs/contact/class/contact.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 1 - path: ../../htdocs/contact/class/contact.class.php - - message: '#^Property Contact\:\:\$email \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -8988,18 +8874,6 @@ parameters: count: 2 path: ../../htdocs/contrat/class/contrat.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/contrat/class/contrat.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/contrat/class/contrat.class.php - - message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -10542,12 +10416,6 @@ parameters: count: 1 path: ../../htdocs/core/class/comment.class.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, CommonObject\|stdClass given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/class/commondocgenerator.class.php - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:get_substitutionarray_each_var_object\(\) expects array\, CommonObject given\.$#' identifier: argument.type @@ -12660,42 +12528,6 @@ parameters: count: 1 path: ../../htdocs/core/filemanagerdol/browser/default/browser.php - - - message: '#^Variable \$conf might not be defined\.$#' - identifier: variable.undefined - count: 1 - path: ../../htdocs/core/filemanagerdol/browser/default/frmactualfolder.php - - - - message: '#^Variable \$conf might not be defined\.$#' - identifier: variable.undefined - count: 1 - path: ../../htdocs/core/filemanagerdol/browser/default/frmcreatefolder.php - - - - message: '#^Variable \$langs might not be defined\.$#' - identifier: variable.undefined - count: 2 - path: ../../htdocs/core/filemanagerdol/browser/default/frmcreatefolder.php - - - - message: '#^Variable \$conf might not be defined\.$#' - identifier: variable.undefined - count: 1 - path: ../../htdocs/core/filemanagerdol/browser/default/frmfolders.php - - - - message: '#^Variable \$conf might not be defined\.$#' - identifier: variable.undefined - count: 1 - path: ../../htdocs/core/filemanagerdol/browser/default/frmresourceslist.php - - - - message: '#^Variable \$conf might not be defined\.$#' - identifier: variable.undefined - count: 1 - path: ../../htdocs/core/filemanagerdol/browser/default/frmupload.php - - message: '#^Variable \$_FILES in isset\(\) always exists and is not nullable\.$#' identifier: isset.variable @@ -13842,12 +13674,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/asset/doc/pdf_standard_asset.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Asset given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/asset/doc/pdf_standard_asset.modules.php - - message: '#^Property pdf_standard_asset\:\:\$cols \(array\\) does not accept non\-empty\-array\\.$#' identifier: assign.propertyType @@ -14100,12 +13926,6 @@ parameters: count: 2 path: ../../htdocs/core/modules/commande/doc/doc_generic_order_odt.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Commande given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/commande/doc/pdf_einstein.modules.php - - message: '#^Parameter \#2 \$addpercent of function vatrate expects bool, int given\.$#' identifier: argument.type @@ -14160,12 +13980,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/commande/doc/pdf_eratosthene.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Commande given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/commande/doc/pdf_eratosthene.modules.php - - message: '#^Parameter \#3 \$posy of method pdf_eratosthene\:\:drawInfoTable\(\) expects int, float given\.$#' identifier: argument.type @@ -14352,12 +14166,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/delivery/doc/pdf_storm.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Delivery given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/delivery/doc/pdf_storm.modules.php - - message: '#^Parameter \#3 \$posy of method pdf_storm\:\:_tableau_info\(\) expects int, float given\.$#' identifier: argument.type @@ -14496,12 +14304,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/expedition/doc/doc_generic_shipment_odt.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Expedition given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/expedition/doc/pdf_espadon.modules.php - - message: '#^Parameter \#4 \$columnText of method CommonDocGenerator\:\:printStdColumnContent\(\) expects string, float given\.$#' identifier: argument.type @@ -14742,12 +14544,6 @@ parameters: count: 6 path: ../../htdocs/core/modules/facture/doc/pdf_crabe.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Facture given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/facture/doc/pdf_crabe.modules.php - - message: '#^Parameter \#3 \$posy of method pdf_crabe\:\:_tableau_info\(\) expects int, float given\.$#' identifier: argument.type @@ -14808,12 +14604,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/facture/doc/pdf_octopus.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Facture given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/facture/doc/pdf_octopus.modules.php - - message: '#^Parameter \#2 \$addpercent of function vatrate expects bool, int given\.$#' identifier: argument.type @@ -15012,12 +14802,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/facture/doc/pdf_sponge.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Facture given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/facture/doc/pdf_sponge.modules.php - - message: '#^Parameter \#2 \$addpercent of function vatrate expects bool, int given\.$#' identifier: argument.type @@ -15462,18 +15246,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/mailings/contacts1.modules.php - - - message: '#^Property mailing_eventorganization\:\:\$require_admin has no type specified\.$#' - identifier: missingType.property - count: 1 - path: ../../htdocs/core/modules/mailings/eventorganization.modules.php - - - - message: '#^Property mailing_eventorganization\:\:\$require_module has no type specified\.$#' - identifier: missingType.property - count: 1 - path: ../../htdocs/core/modules/mailings/eventorganization.modules.php - - message: '#^Property mailing_fraise\:\:\$require_admin has no type specified\.$#' identifier: missingType.property @@ -16404,12 +16176,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/movement/doc/pdf_standard_movementstock.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Entrepot\|MouvementStock given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/movement/doc/pdf_standard_movementstock.modules.php - - message: '#^Parameter \#5 \$w of function pdf_writelinedesc expects int, float given\.$#' identifier: argument.type @@ -16488,12 +16254,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/mrp/doc/pdf_vinci.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Mo given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/mrp/doc/pdf_vinci.modules.php - - message: '#^Parameter \#2 \$addpercent of function vatrate expects bool, int given\.$#' identifier: argument.type @@ -16932,12 +16692,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/propale/doc/pdf_azur.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Propal given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/propale/doc/pdf_azur.modules.php - - message: '#^Parameter \#2 \$addpercent of function vatrate expects bool, int given\.$#' identifier: argument.type @@ -16986,12 +16740,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/propale/doc/pdf_cyan.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, Propal given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/propale/doc/pdf_cyan.modules.php - - message: '#^Parameter \#2 \$addpercent of function vatrate expects bool, int given\.$#' identifier: argument.type @@ -17346,12 +17094,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/stocktransfer/doc/pdf_eagle_proforma.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, StockTransfer given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/stocktransfer/doc/pdf_eagle_proforma.modules.php - - message: '#^Parameter \#4 \$posy of method pdf_eagle_proforma\:\:drawTotalTable\(\) expects int, float given\.$#' identifier: argument.type @@ -17490,12 +17232,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/supplier_invoice/doc/doc_generic_supplier_invoice_odt.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, FactureFournisseur given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/supplier_invoice/doc/pdf_canelle.modules.php - - message: '#^Parameter \#2 \$addpercent of function vatrate expects bool, int given\.$#' identifier: argument.type @@ -17538,24 +17274,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/supplier_invoice/doc/pdf_canelle.modules.php - - - message: '#^Property mod_facture_fournisseur_cactus\:\:\$prefixcreditnote has no type specified\.$#' - identifier: missingType.property - count: 1 - path: ../../htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php - - - - message: '#^Property mod_facture_fournisseur_cactus\:\:\$prefixdeposit has no type specified\.$#' - identifier: missingType.property - count: 1 - path: ../../htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php - - - - message: '#^Property mod_facture_fournisseur_cactus\:\:\$prefixinvoice has no type specified\.$#' - identifier: missingType.property - count: 1 - path: ../../htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:get_substitutionarray_each_var_object\(\) expects array\, CommandeFournisseur given\.$#' identifier: argument.type @@ -17598,12 +17316,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, CommandeFournisseur given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/supplier_order/doc/pdf_cornas.modules.php - - message: '#^Parameter \#2 \$addpercent of function vatrate expects bool, int given\.$#' identifier: argument.type @@ -17862,12 +17574,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/supplier_proposal/doc/pdf_aurore.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, SupplierProposal given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/supplier_proposal/doc/pdf_aurore.modules.php - - message: '#^Parameter \#2 \$addpercent of function vatrate expects bool, int given\.$#' identifier: argument.type @@ -17898,12 +17604,6 @@ parameters: count: 1 path: ../../htdocs/core/modules/supplier_proposal/doc/pdf_zenith.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, SupplierProposal given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/core/modules/supplier_proposal/doc/pdf_zenith.modules.php - - message: '#^Parameter \#2 \$addpercent of function vatrate expects bool, int given\.$#' identifier: argument.type @@ -19248,12 +18948,6 @@ parameters: count: 1 path: ../../htdocs/cron/class/cronjob.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 4 - path: ../../htdocs/cron/class/cronjob.class.php - - message: '#^Property Cronjob\:\:\$command \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -19698,12 +19392,6 @@ parameters: count: 5 path: ../../htdocs/don/class/paymentdonation.class.php - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 3 - path: ../../htdocs/don/class/paymentdonation.class.php - - message: '#^Property PaymentDonation\:\:\$amount \(float\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -20742,18 +20430,6 @@ parameters: count: 1 path: ../../htdocs/expedition/class/expedition.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/expedition/class/expedition.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/expedition/class/expedition.class.php - - message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -21324,24 +21000,6 @@ parameters: count: 1 path: ../../htdocs/expensereport/class/paymentexpensereport.class.php - - - message: '#^Property CommonObject\:\:\$note \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 3 - path: ../../htdocs/expensereport/class/paymentexpensereport.class.php - - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 1 - path: ../../htdocs/expensereport/class/paymentexpensereport.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 1 - path: ../../htdocs/expensereport/class/paymentexpensereport.class.php - - message: '#^Property PaymentExpenseReport\:\:\$amount \(float\|int\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -22182,18 +21840,6 @@ parameters: count: 2 path: ../../htdocs/fourn/class/fournisseur.commande.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/fourn/class/fournisseur.commande.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/fourn/class/fournisseur.commande.class.php - - message: '#^Property CommonObject\:\:\$ref_ext \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -25572,18 +25218,6 @@ parameters: count: 1 path: ../../htdocs/loan/class/loan.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 1 - path: ../../htdocs/loan/class/loan.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 1 - path: ../../htdocs/loan/class/loan.class.php - - message: '#^Property Loan\:\:\$account_capital \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -25632,18 +25266,6 @@ parameters: count: 1 path: ../../htdocs/loan/class/loanschedule.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/loan/class/loanschedule.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/loan/class/loanschedule.class.php - - message: '#^Property LoanSchedule\:\:\$fk_bank \(int\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -25692,18 +25314,6 @@ parameters: count: 1 path: ../../htdocs/loan/class/paymentloan.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 3 - path: ../../htdocs/loan/class/paymentloan.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 3 - path: ../../htdocs/loan/class/paymentloan.class.php - - message: '#^Property PaymentLoan\:\:\$amount_capital \(float\|int\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -26466,12 +26076,6 @@ parameters: count: 1 path: ../../htdocs/modulebuilder/template/core/modules/mymodule/doc/pdf_standard_myobject.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, MyObject given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/modulebuilder/template/core/modules/mymodule/doc/pdf_standard_myobject.modules.php - - message: '#^Parameter \#3 \$tab_height of method pdf_standard_myobject\:\:_tableau\(\) expects int, float given\.$#' identifier: argument.type @@ -28128,18 +27732,6 @@ parameters: count: 1 path: ../../htdocs/product/class/product.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/product/class/product.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/product/class/product.class.php - - message: '#^Property Product\:\:\$accountancy_code_buy \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -30468,18 +30060,6 @@ parameters: count: 2 path: ../../htdocs/projet/class/task.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/projet/class/task.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/projet/class/task.class.php - - message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -32772,18 +32352,6 @@ parameters: count: 1 path: ../../htdocs/reception/class/reception.class.php - - - message: '#^Property CommonObject\:\:\$note_private \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/reception/class/reception.class.php - - - - message: '#^Property CommonObject\:\:\$note_public \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 2 - path: ../../htdocs/reception/class/reception.class.php - - message: '#^Property CommonObject\:\:\$ref \(string\) in isset\(\) is not nullable\.$#' identifier: isset.property @@ -33432,12 +33000,6 @@ parameters: count: 1 path: ../../htdocs/recruitment/core/modules/recruitment/doc/pdf_standard_recruitmentjobposition.modules.php - - - message: '#^Parameter \#1 \$object of method CommonDocGenerator\:\:getExtrafieldsInHtml\(\) expects CommonObjectLine, RecruitmentJobPosition given\.$#' - identifier: argument.type - count: 1 - path: ../../htdocs/recruitment/core/modules/recruitment/doc/pdf_standard_recruitmentjobposition.modules.php - - message: '#^Variable \$outputlangsbis might not be defined\.$#' identifier: variable.undefined @@ -33942,12 +33504,6 @@ parameters: count: 2 path: ../../htdocs/salaries/class/paymentsalary.class.php - - - message: '#^Property CommonObject\:\:\$note \(string\) in isset\(\) is not nullable\.$#' - identifier: isset.property - count: 3 - path: ../../htdocs/salaries/class/paymentsalary.class.php - - message: '#^Property PaymentSalary\:\:\$amount \(float\) in isset\(\) is not nullable\.$#' identifier: isset.property diff --git a/dev/examples/zapier/package.json b/dev/examples/zapier/package.json index ef70b2af8fdc6..896c305761f48 100644 --- a/dev/examples/zapier/package.json +++ b/dev/examples/zapier/package.json @@ -4,7 +4,7 @@ "description": "An app for connecting Dolibarr to the Zapier platform.", "repository": "Dolibarr/dolibarr", "homepage": "https://www.dolibarr.org/", - "author": "Frédéric France ", + "author": "Frédéric France ", "license": "BSD-3-Clause", "main": "index.js", "scripts": { diff --git a/htdocs/core/boxes/box_dolibarr_state_board.php b/htdocs/core/boxes/box_dolibarr_state_board.php index d5b47a101f936..13d563c60dc0d 100644 --- a/htdocs/core/boxes/box_dolibarr_state_board.php +++ b/htdocs/core/boxes/box_dolibarr_state_board.php @@ -1,9 +1,9 @@ - * Copyright (C) 2004-2010 Laurent Destailleur - * Copyright (C) 2005-2009 Regis Houssin - * Copyright (C) 2015-2024 Frederic France - * Copyright (C) 2024 MDW +/* Copyright (C) 2003-2007 Rodolphe Quiedeville + * Copyright (C) 2004-2010 Laurent Destailleur + * Copyright (C) 2005-2009 Regis Houssin + * Copyright (C) 2015-2024 Frédéric France + * Copyright (C) 2024 MDW * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/htdocs/core/boxes/box_factures_imp.php b/htdocs/core/boxes/box_factures_imp.php index cf4d4967a1668..fb7e8f914ea13 100644 --- a/htdocs/core/boxes/box_factures_imp.php +++ b/htdocs/core/boxes/box_factures_imp.php @@ -1,10 +1,10 @@ - * Copyright (C) 2004-2007 Laurent Destailleur - * Copyright (C) 2005-2009 Regis Houssin - * Copyright (C) 2015-2019 Frederic France - * Copyright (C) 2024 MDW - * Copyright (C) 2024 Alexandre Spangaro +/* Copyright (C) 2003-2007 Rodolphe Quiedeville + * Copyright (C) 2004-2007 Laurent Destailleur + * Copyright (C) 2005-2009 Regis Houssin + * Copyright (C) 2015-2024 Frédéric France + * Copyright (C) 2024 MDW + * Copyright (C) 2024 Alexandre Spangaro * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/htdocs/core/class/commondocgenerator.class.php b/htdocs/core/class/commondocgenerator.class.php index bb2dcaf25ddda..6514a722bc109 100644 --- a/htdocs/core/class/commondocgenerator.class.php +++ b/htdocs/core/class/commondocgenerator.class.php @@ -1586,7 +1586,7 @@ public function getExtrafieldContent($object, $extrafieldKey, $outputlangs = nul /** * display extrafields columns content * - * @param CommonObjectLine $object line of common object + * @param CommonObject|CommonObjectLine $object line of common object * @param Translate $outputlangs Output language * @param array $params array of additional parameters * @return string Html string diff --git a/htdocs/core/filemanagerdol/browser/default/frmactualfolder.php b/htdocs/core/filemanagerdol/browser/default/frmactualfolder.php index 1304afa175474..819d4ba69a727 100644 --- a/htdocs/core/filemanagerdol/browser/default/frmactualfolder.php +++ b/htdocs/core/filemanagerdol/browser/default/frmactualfolder.php @@ -23,6 +23,9 @@ // Load Dolibarr environment require '../../../../main.inc.php'; +/** + * @var Conf $conf + */ top_httphead(); diff --git a/htdocs/core/filemanagerdol/browser/default/frmcreatefolder.php b/htdocs/core/filemanagerdol/browser/default/frmcreatefolder.php index 3189ae92ee826..fa64d6fbc1d7b 100644 --- a/htdocs/core/filemanagerdol/browser/default/frmcreatefolder.php +++ b/htdocs/core/filemanagerdol/browser/default/frmcreatefolder.php @@ -23,6 +23,10 @@ // Load Dolibarr environment require '../../../../main.inc.php'; +/** + * @var Conf $conf + * @var Translate $langs + */ $langs->load("ecm"); diff --git a/htdocs/core/filemanagerdol/browser/default/frmfolders.php b/htdocs/core/filemanagerdol/browser/default/frmfolders.php index b2ef70c237415..174ca34897a9c 100644 --- a/htdocs/core/filemanagerdol/browser/default/frmfolders.php +++ b/htdocs/core/filemanagerdol/browser/default/frmfolders.php @@ -23,6 +23,9 @@ // Load Dolibarr environment require '../../../../main.inc.php'; +/** + * @var Conf $conf + */ top_httphead(); diff --git a/htdocs/core/filemanagerdol/browser/default/frmresourceslist.php b/htdocs/core/filemanagerdol/browser/default/frmresourceslist.php index 560df3020665f..fdc551e93394a 100644 --- a/htdocs/core/filemanagerdol/browser/default/frmresourceslist.php +++ b/htdocs/core/filemanagerdol/browser/default/frmresourceslist.php @@ -23,6 +23,9 @@ // Load Dolibarr environment require '../../../../main.inc.php'; +/** + * @var Conf $conf + */ top_httphead(); diff --git a/htdocs/core/filemanagerdol/browser/default/frmupload.php b/htdocs/core/filemanagerdol/browser/default/frmupload.php index e5807bd41c726..17a2be8725b80 100644 --- a/htdocs/core/filemanagerdol/browser/default/frmupload.php +++ b/htdocs/core/filemanagerdol/browser/default/frmupload.php @@ -23,6 +23,9 @@ // Load Dolibarr environment require '../../../../main.inc.php'; +/** + * @var Conf $conf + */ top_httphead(); diff --git a/htdocs/core/modules/asset/mod_asset_standard.php b/htdocs/core/modules/asset/mod_asset_standard.php index 90ea78e702769..d3db8afc8329a 100644 --- a/htdocs/core/modules/asset/mod_asset_standard.php +++ b/htdocs/core/modules/asset/mod_asset_standard.php @@ -2,8 +2,8 @@ /* Copyright (C) 2005-2010 Laurent Destailleur * Copyright (C) 2005-2009 Regis Houssin * Copyright (C) 2022-2024 Frédéric France - * Copyright (C) 2022 Frédéric France - * Copyright (C) 2024 MDW + * Copyright (C) 2022 Frédéric France + * Copyright (C) 2024 MDW * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/htdocs/core/modules/modBookCal.class.php b/htdocs/core/modules/modBookCal.class.php index 43210e6dfe98d..9bd1f57ca2933 100644 --- a/htdocs/core/modules/modBookCal.class.php +++ b/htdocs/core/modules/modBookCal.class.php @@ -1,8 +1,8 @@ * Copyright (C) 2018-2019 Nicolas ZABOURI - * Copyright (C) 2019-2024 Frédéric France - * Copyright (C) 2024 MDW + * Copyright (C) 2019-2024 Frédéric France + * Copyright (C) 2024 MDW * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/htdocs/core/modules/modStockTransfer.class.php b/htdocs/core/modules/modStockTransfer.class.php index c797136b3353b..88cc66384f4aa 100644 --- a/htdocs/core/modules/modStockTransfer.class.php +++ b/htdocs/core/modules/modStockTransfer.class.php @@ -1,9 +1,9 @@ * Copyright (C) 2018-2019 Nicolas ZABOURI - * Copyright (C) 2019-2022 Frédéric France + * Copyright (C) 2019-2024 Frédéric France * Copyright (C) 2021 Gauthier VERDOL - * Copyright (C) 2024 MDW + * Copyright (C) 2024 MDW * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/htdocs/core/modules/modWebhook.class.php b/htdocs/core/modules/modWebhook.class.php index 26ffcb1044bbf..c3a64bfd42d53 100644 --- a/htdocs/core/modules/modWebhook.class.php +++ b/htdocs/core/modules/modWebhook.class.php @@ -1,7 +1,7 @@ * Copyright (C) 2018-2019 Nicolas ZABOURI - * Copyright (C) 2019-2020 Frédéric France + * Copyright (C) 2019-2024 Frédéric France * Copyright (C) 2024 MDW * * This program is free software; you can redistribute it and/or modify diff --git a/htdocs/core/modules/modZapier.class.php b/htdocs/core/modules/modZapier.class.php index b732329f16688..7f316917a610c 100644 --- a/htdocs/core/modules/modZapier.class.php +++ b/htdocs/core/modules/modZapier.class.php @@ -1,6 +1,6 @@ - * Copyright (C) 2019 Frédéric France + * Copyright (C) 2019-2024 Frédéric France * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/htdocs/core/modules/printing/printipp.modules.php b/htdocs/core/modules/printing/printipp.modules.php index 88dd5f7efbb7b..2ea6a82d57d28 100644 --- a/htdocs/core/modules/printing/printipp.modules.php +++ b/htdocs/core/modules/printing/printipp.modules.php @@ -1,7 +1,7 @@ - * Copyright (C) 2024 MDW + * Copyright (C) 2014-2024 Frédéric France + * Copyright (C) 2024 MDW * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/htdocs/core/modules/product_batch/mod_lot_advanced.php b/htdocs/core/modules/product_batch/mod_lot_advanced.php index 91f68ac8a7f18..35fa10f867e17 100644 --- a/htdocs/core/modules/product_batch/mod_lot_advanced.php +++ b/htdocs/core/modules/product_batch/mod_lot_advanced.php @@ -3,7 +3,7 @@ * Copyright (C) 2004-2007 Laurent Destailleur * Copyright (C) 2005-2009 Regis Houssin * Copyright (C) 2008 Raphael Bertrand (Resultic) - * Copyright (C) 2019 Frédéric France + * Copyright (C) 2019-2024 Frédéric France * Copyright (C) 2021 Christophe Battarel * Copyright (C) 2024 MDW * diff --git a/htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php b/htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php index 5f57fc3d1fa9a..aa760b7c50da4 100644 --- a/htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php +++ b/htdocs/core/modules/supplier_invoice/mod_facture_fournisseur_cactus.php @@ -58,10 +58,19 @@ class mod_facture_fournisseur_cactus extends ModeleNumRefSuppliersInvoices */ public $name = 'Cactus'; + /** + * @var string + */ public $prefixinvoice = 'SI'; + /** + * @var string + */ public $prefixcreditnote = 'SA'; + /** + * @var string + */ public $prefixdeposit = 'SD'; diff --git a/test/phpunit/FactureTest.php b/test/phpunit/FactureTest.php index 2fc0bb6d67d13..169ae9c513238 100644 --- a/test/phpunit/FactureTest.php +++ b/test/phpunit/FactureTest.php @@ -1,8 +1,8 @@ - * Copyright (C) 2018 Frédéric France - * Copyright (C) 2023 Alexandre Janniaux - * Copyright (C) 2024 MDW +/* Copyright (C) 2010 Laurent Destailleur + * Copyright (C) 2018-2024 Frédéric France + * Copyright (C) 2023 Alexandre Janniaux + * Copyright (C) 2024 MDW * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -36,7 +36,7 @@ if (empty($user->id)) { print "Load permissions for admin user nb 1\n"; $user->fetch(1); - $user->getrights(); + $user->loadRights(); } $conf->global->MAIN_DISABLE_ALL_MAILS = 1; diff --git a/test/phpunit/InventoryTest.php b/test/phpunit/InventoryTest.php index 7761608d1a6b4..57b416ee04be0 100644 --- a/test/phpunit/InventoryTest.php +++ b/test/phpunit/InventoryTest.php @@ -1,8 +1,8 @@ - * Copyright (C) 2018 Frédéric France - * Copyright (C) 2023 Alexandre Janniaux - * Copyright (C) 2024 MDW +/* Copyright (C) 2010 Laurent Destailleur + * Copyright (C) 2018-2024 Frédéric France + * Copyright (C) 2023 Alexandre Janniaux + * Copyright (C) 2024 MDW * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by