Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW Add order tags #22849

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

NEW Add order tags #22849

wants to merge 17 commits into from
+553 −95

Conversation

FlorentPoinsaut
Copy link
Contributor

CLOSE|Close #22848

NEW|Add order tags

@FlorentPoinsaut FlorentPoinsaut mentioned this pull request Nov 15, 2022
Closed
@eldy eldy added the PR postponed PR is postponed (will be processed later). Ie: feature pushed during a beta or need transition steps label Nov 15, 2022
@eldy eldy added the PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) label Oct 16, 2023
@FlorentPoinsaut FlorentPoinsaut force-pushed the feat-order-tags branch 2 times, most recently from db7a8c7 to c3c7813 Compare October 17, 2023 14:31
@josett225
Copy link
Contributor

Hi @FlorentPoinsaut
Very good initiative. If I am not wrong, this is not available on proposal also. Any chance to add tags on Proposals too?
Best Regards
Jose

@FlorentPoinsaut
Copy link
Contributor Author

Hi @josett225,
Thank you. Exactly, I only work for order and invoice (customer and supplier). I have no plan to implement link between proposals and tags. Sorry.
Regards,

@eldy eldy added PR mixing structure and code change A PR with SQL addition must be pushed without code change. Split PR to submit structure only first. and removed PR postponed PR is postponed (will be processed later). Ie: feature pushed during a beta or need transition steps PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) labels Jun 16, 2024
@eldy
Copy link
Member

eldy commented Jun 16, 2024 •
edited
Loading

Sorry to keep this PR open too long... until conflict has become to important to be able to merge it. Mea culpa.

To match the contributions rules, you must first submit a PR for database structure addition, and then, once database change is validated, you can submit the new code.

@FlorentPoinsaut FlorentPoinsaut mentioned this pull request Aug 1, 2024
Merged
@FlorentPoinsaut
Copy link
Contributor Author

Hi @eldy!
Could you explain me how to add the SQL new tables creation to the test?

@eldy
Copy link
Member

eldy commented Aug 27, 2024 •
edited
Loading

Hi @eldy!
Could you explain me how to add the SQL new tables creation to the test?

You must adf the file to create the table into directory /install/mysql/tables
Then add the same instruction into file /install/mysql/migration/20.0.0-21.0.0.sql

@eldy
Copy link
Member

eldy commented Nov 13, 2024

Waiting PR with structure addition first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR mixing structure and code change A PR with SQL addition must be pushed without code change. Split PR to submit structure only first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add order tags
3 participants
@FlorentPoinsaut @josett225 @eldy