-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print sign to pos PDF defini #24044
Open
BB2A-Anthony
wants to merge
32
commits into
Dolibarr:develop
Choose a base branch
from
BB2A-Anthony:NEW---PDF-Pos-sign
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Print sign to pos PDF defini #24044
+88
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EW---PDF-Pos-sign
…EW---PDF-Pos-sign
…EW---PDF-Pos-sign
@eldy your opinion |
eldy
reviewed
Mar 12, 2023
eldy
added
the
Discussion
Some questions or discussions are opened and wait answers of author or other people to be processed
label
Mar 12, 2023
…EW---PDF-Pos-sign
…EW---PDF-Pos-sign
According to contributing rules, database structure change must be done in a separated PR. So structure is validated first. |
eldy
added
the
PR to fix - See feedback in comments
PR needs to be fixed to be integrated (some comments should describes the fix to do)
label
May 20, 2023
…EW---PDF-Pos-sign
…EW---PDF-Pos-sign
… branch 'develop' of https://github.com/Dolibarr/dolibarr into NEW---PDF-Pos-sign
Can you help me to fix conflicts ? |
eldy
removed
the
Discussion
Some questions or discussions are opened and wait answers of author or other people to be processed
label
Oct 6, 2024
Hi @eldy It's ok for me i have testing all possibility! |
eldy
added
PR to fix - Conflict or CI error to solve
The PHP unit tests return something wrong. Check details to know what to fix or solve the conflicts.
and removed
PR to fix - See feedback in comments
PR needs to be fixed to be integrated (some comments should describes the fix to do)
labels
Nov 7, 2024
@BB2A-Anthony The CI returns errors that looks to be bug in the new code.an you check ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR to fix - Conflict or CI error to solve
The PHP unit tests return something wrong. Check details to know what to fix or solve the conflicts.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW|New [Save the pos print sign]
[Long description]
#24842 PR database increment
Save pos to print sign for onligne sign
Pages if other documents are merged after like pdf product
posX
posY
Height
Width