Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print sign to pos PDF defini #24044

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from

Conversation

BB2A-Anthony
Copy link
Contributor

@BB2A-Anthony BB2A-Anthony commented Feb 24, 2023

NEW|New [Save the pos print sign]

[Long description]

#24842 PR database increment

Save pos to print sign for onligne sign

Pages if other documents are merged after like pdf product
posX
posY
Height
Width

@BB2A-Anthony
Copy link
Contributor Author

@eldy your opinion

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Mar 12, 2023
@BB2A-Anthony BB2A-Anthony requested a review from eldy April 26, 2023 12:57
@eldy
Copy link
Member

eldy commented May 20, 2023

According to contributing rules, database structure change must be done in a separated PR. So structure is validated first.

@eldy eldy added the PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) label May 20, 2023
@BB2A-Anthony
Copy link
Contributor Author

According to contributing rules, database structure change must be done in a separated PR. So structure is validated first.

@eldy it's done #24842

@eldy
Copy link
Member

eldy commented Oct 6, 2024

Can you help me to fix conflicts ?

@eldy eldy removed the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Oct 6, 2024
@BB2A-Anthony
Copy link
Contributor Author

Can you help me to fix conflicts ?

Hi @eldy It's ok for me i have testing all possibility!

@eldy eldy added PR to fix - Conflict or CI error to solve The PHP unit tests return something wrong. Check details to know what to fix or solve the conflicts. and removed PR to fix - See feedback in comments PR needs to be fixed to be integrated (some comments should describes the fix to do) labels Nov 7, 2024
@eldy
Copy link
Member

eldy commented Nov 13, 2024

@BB2A-Anthony The CI returns errors that looks to be bug in the new code.an you check ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix - Conflict or CI error to solve The PHP unit tests return something wrong. Check details to know what to fix or solve the conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants