Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW : add titles for wysiwig editor in eldy theme #26787

Conversation

samifilali
Copy link
Contributor

FIX

  • add titles for wysiwig editor in eldy theme

atm-server pushed a commit to ATM-Consulting/dolibarr that referenced this pull request Nov 21, 2023
…iwig (theme eldy) suite au ticket DA024097 et en attendant la PR Standard : Dolibarr#26787
@eldy
Copy link
Member

eldy commented Nov 21, 2023

Looks more as a not yet provided feature than a bug.
As this add a new feature for end user, this must be pushed into develop. Also this option may generates troubles with rest of features (like pdf generator, or function to calculate size of note content), so i recommand to add this only if a hidden constant if set.

@eldy eldy added the PR no feature/refacto into freezed/released branch PR can't be accepted because it's a feature change or refactoring pushed into a stable frozen branch label Nov 21, 2023
@eldy eldy changed the title FIX : add titles for wysiwig editor in eldy theme NEW : add titles for wysiwig editor in eldy theme Nov 21, 2023
@samifilali
Copy link
Contributor Author

I can do it if necessary but this functionality was present until version 12 of dolibarr which is why I considered it as a fix

@samifilali samifilali added Discussion Some questions or discussions are opened and wait answers of author or other people to be processed and removed PR no feature/refacto into freezed/released branch PR can't be accepted because it's a feature change or refactoring pushed into a stable frozen branch labels Nov 21, 2023
@eldy
Copy link
Member

eldy commented Nov 23, 2023

Yes. It was removed because this options generates a lot of problem with no solution to fix them (like pdf generation that has bad pagination, function to calculate size of note content that is wrong). Using it inside notes and description of lines must be avoid. This is why i recommand to add this only if a hidden constant if set.

@samifilali
Copy link
Contributor Author

how can I do this? It's in a js file, there is no js context?

@eldy
Copy link
Member

eldy commented Nov 13, 2024

how can I do this? It's in a js file, there is no js context?

Right. Did not found solution to set ckeditor menu toolbar on the fly so it was reintroduced into v21.

@eldy eldy closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants