NEW funclionality to Clone user with permissions and categories #29773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jun 4, 2024
htdocs/user/class/user.class.php
Outdated
| $sql .= " SELECT 1"; | ||
| $sql .= " FROM ".$this->db->prefix()."user_rights dest"; | ||
| $sql .= " WHERE dest.entity = src.entity"; | ||
| $sql .= " AND dest.fk_user = ".$this->db->escape($toId); |
There was a problem hiding this comment.
It is an int so must use
$sql .= " AND dest.fk_user = ".((int) $toId);
eldy
reviewed
Jun 4, 2024
htdocs/user/class/user.class.php
Outdated
|
|
||
| // Construction de la requête d'insertion | ||
| $sql = "INSERT INTO ".$this->db->prefix()."user_rights (entity, fk_user, fk_id)"; | ||
| $sql .= " SELECT entity, ".$this->db->escape($toId).", fk_id"; |
There was a problem hiding this comment.
It is an int so must use
$sql .= " SELECT entity, ".((int) $toId).", fk_id";
eldy
reviewed
Jun 4, 2024
htdocs/user/class/user.class.php
Outdated
| $categorystatic = new Categorie($this->db); | ||
|
|
||
| $sql = "INSERT INTO ".$this->db->prefix()."categorie_".(empty($categorystatic->MAP_CAT_TABLE[$type]) ? $type : $categorystatic->MAP_CAT_TABLE[$type])." (fk_categorie, fk_user)"; | ||
| $sql .= " SELECT fk_categorie, $toId FROM ".$this->db->prefix()."categorie_".(empty($categorystatic->MAP_CAT_TABLE[$type]) ? $type : $categorystatic->MAP_CAT_TABLE[$type]); |
eldy
added
the
PR to fix - See feedback in comments
eldy
added
PR postponed
|
@lamrani002 it will probably be necessary to adapt the cloning functions when Multicompany uses user centralization on the main entity! |
An easy to do first step can be to show the clone feature only if user is in same entity than current entity. So cloning is kept always in same entity. |
eldy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW|New functionality to clone user