Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX : DEVELOP pdf space lost with images at bottom of Cyan PDF #31273

Merged
merged 25 commits into from
Dec 9, 2024
Merged

FIX : DEVELOP pdf space lost with images at bottom of Cyan PDF #31273

merged 25 commits into from
Dec 9, 2024

Conversation

thersane-john
Copy link
Contributor

@thersane-john thersane-john commented Oct 4, 2024 •
edited
Loading

FIX

When the MAIN_GENERATE_PROPOSALS_WITH_PICTURE conf is enabled in your Dolibarr, the page break behavior is "broken" and page breaks are too large.

I also fix the sequence of images between each line. So they don't overlap if the description is lower than the image.

Before PATCH
github screen 001

After PATCH
github screen 002

@thersane-john thersane-john marked this pull request as ready for review October 7, 2024 07:22
@thersane-john thersane-john mentioned this pull request Oct 7, 2024
Closed
@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Oct 7, 2024
@thersane-john thersane-john changed the title FIX : v20 pdf space lost with images at bottom of Cyan PDF WAIT : FIX : v20 pdf space lost with images at bottom of Cyan PDF Oct 8, 2024
@thersane-john thersane-john marked this pull request as draft October 8, 2024 09:51
@thersane-john thersane-john changed the title WAIT : FIX : v20 pdf space lost with images at bottom of Cyan PDF FIX : v20 pdf space lost with images at bottom of Cyan PDF Oct 9, 2024
@thersane-john thersane-john marked this pull request as ready for review October 9, 2024 07:51
@thersane-john thersane-john requested a review from eldy October 17, 2024 12:07
@thersane-john thersane-john mentioned this pull request Oct 17, 2024
Merged
@thersane-john thersane-john requested a review from sonikf October 22, 2024 12:42
sonikf
sonikf approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@sonikf sonikf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now!

htdocs/core/modules/propale/doc/pdf_cyan.modules.php Show resolved Hide resolved
@thersane-john thersane-john changed the base branch from 20.0 to develop October 24, 2024 05:44
@thersane-john thersane-john changed the base branch from develop to 20.0 October 24, 2024 05:45
@thersane-john thersane-john changed the base branch from 20.0 to develop October 24, 2024 09:16
@thersane-john thersane-john changed the title FIX : v20 pdf space lost with images at bottom of Cyan PDF FIX : DEVELOP pdf space lost with images at bottom of Cyan PDF Oct 24, 2024
@thersane-john thersane-john marked this pull request as draft October 24, 2024 10:07
@thersane-john thersane-john marked this pull request as ready for review October 24, 2024 10:09
@thersane-john
Copy link
Contributor Author

@eldy can you check please ?

@eldy eldy merged commit 5e55616 into Dolibarr:develop Dec 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonikf sonikf sonikf approved these changes

@eldy eldy Awaiting requested review from eldy

Assignees
No one assigned
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thersane-john @eldy @sonikf