Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unit output (use_short_label) #31706

Open
wants to merge 1 commit into
base: 20.0
Choose a base branch
from

Conversation

Humml87
Copy link
Contributor

@Humml87 Humml87 commented Nov 5, 2024

Now the same short Labels are used.

image

P.S. in transiflex no resources exist for ....Short, which is generated from 'measuringUnitString'.

@eldy
Copy link
Member

eldy commented Nov 6, 2024

We use the param 1 because we are in a table where we must save spaces, so we ask to use the very short label. So for "piece", we should get "p".
this is strange, old code
$unitforline = measuringUnitString($line->fk_unit, '', '', 1);
seems to return correctly "p"
If using 2, we will get PieceShort. So 1 seems the correct value. Did i miss something ?

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants