FIX ticket list : type_code multiselect search can be an empty value.…

[thomas-Ngr]

Fix multiselect on ticket list would allow empty value for type_code

On ticket list, the search for type_code is a multiselect. It can receive an empty value that would mean 'type_code is not set'.
Since type_code is a mandatory value, a search on value 'is not set' should not be allowed.

[eldy]

The empty value into the select list means "We don't want any filter". And we should be able to not set any filter on this field so the empty choice should remain into the combo, but no filter should be done in this case.

[thomas-Ngr]

You are right. Problem is, if we chose this empty value we get a nice error page (here an abstract). Tested on a fresh V17 install without any module.

with this nice request

SELECT t.rowid,t.entity,t.ref,t.track_id,t.fk_user_create,t.origin_email,t.subject,t.type_code,t.category_code,t.severity_code,t.fk_soc,t.notify_tiers_at_create,t.fk_project,t.datec,t.date_read,t.date_last_msg_sent,t.fk_user_assign,t.date_close,t.tms,t.message,t.email_msgid,t.progress,t.email_date,t.resolution,t.fk_statut,t.import_key FROM llx_ticket as t LEFT JOIN llx_societe as s ON (t.fk_soc = s.rowid) WHERE t.entity IN (1) AND (type_code IN ()) ORDER BY t.datec DESC LIMIT 21

containing this nice WITH clause :

AND (type_code IN ())

---

The solution is to remove empty values from the search array. User may still be confused by being able to chose empty value, but at least the search will work.

[eldy]

Solution is to fix the part of code that generates the SQL by adding a test so if no filter is provided, the SQL must not include the "AND (type_code IN ..." at all.

[eldy]

What is value of $newarrayoftypecodes here ?

[thomas-Ngr]

It depends on what was filtered by the user.

• if no filter, $newarrayoftypecodes == []
• if filter 'empty value', $newarrayoftypecodes == [0 => '']
• if filter 'HELP', $newarrayoftypecodes == [0 => 'HELP']
• if filter 'HELP' + 'empty value', $newarrayoftypecodes == [0 => '', 1 => 'HELP'] (I observed that the empty value comes on index 0)

[eldy]

So we must found when the entry 0 => '' is added to disabled it.
I do not experience troubles in develop so may be you can have a look to fix the same way.

[thomas-Ngr]

I do not experience troubles in develop

Well, I do. On a fresh install on commit 2eb5bca from Wed Nov 13 11:36:05 . Please see the screencast. NB - the automatic setting of choice 'other' is not in v17, which I am fixing.

Anyway, this WHERE clause is generated in natural_search() function, when you pass it an array containing only empty string values ['', '']. I fixed it.