Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW - PDF pos sign database #24842

Closed

Conversation

BB2A-Anthony
Copy link
Contributor

@BB2A-Anthony BB2A-Anthony commented May 22, 2023

NEW|New [PDF pos sign database]

[Long description]

#24044 PR for Increment to propal

Save pos to print sign for onligne sign

Pages if other documents are merged after like pdf product
posX
posY
Height
Width

@BB2A-Anthony
Copy link
Contributor Author

@eldy Up for 18 please

@@ -83,6 +83,9 @@ ALTER TABLE llx_bank_account ADD COLUMN owner_country_id integer DEFAULT NULL;

ALTER TABLE llx_prelevement_bons ADD COLUMN fk_bank_account integer DEFAULT NULL;

ALTER TABLE llx_propal ADD COLUMN model_pdf_pos_sign VARCHAR(10) DEFAULT NULL AFTER last_main_doc;
Copy link
Member

@eldy eldy May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide an example of value you plan to store in this field ?
My understanding is that field is dedicated to store position and page of the signature. If right the size of varchar 10 seems too small.

Copy link
Contributor Author

@BB2A-Anthony BB2A-Anthony May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eldy

It's value 25:10:15:30

#24044 PR for Increment to propal

if you wish, I am willing to do it for the other signatures online when the one if validated

posX:posY:Height:Width

Copy link
Member

@eldy eldy May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So varchar(10) seems to small. May be a varchar(32) is more ready for such feature and future enhancement?

Copy link
Contributor Author

@BB2A-Anthony BB2A-Anthony May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eldy ok for me i changed

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label May 25, 2023
@eldy eldy closed this in 04a1b6b Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants