Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW - PDF pos sign database #24842

Closed
wants to merge 26 commits into from
Closed

NEW - PDF pos sign database #24842

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8a78134
SQL
Feb 6, 2023
80efbd3
Class Propal
Feb 24, 2023
1ef16f6
model cyan
Feb 24, 2023
4c58867
Define signing position
Feb 24, 2023
2ed3f0e
Print sign to pos PDF
Feb 24, 2023
265e41d
Merge branch 'develop' into NEW---PDF-Pos-sign
BB2A-Anthony Feb 25, 2023
d4583f0
Merge branch 'develop' of https://github.com/Dolibarr/dolibarr into N…
Feb 27, 2023
a2d406d
Merge branch 'develop' of https://github.com/Dolibarr/dolibarr into N…
Mar 2, 2023
b602b3d
Use var exist and rewite
Mar 2, 2023
035ffc8
Merge branch 'develop' of https://github.com/Dolibarr/dolibarr into N…
Mar 7, 2023
ffd82ec
del field
Mar 20, 2023
d0ea75d
Merge branch 'develop' of https://github.com/Dolibarr/dolibarr into N…
Mar 21, 2023
2e3a767
Merge branch 'develop' of https://github.com/Dolibarr/dolibarr into N…
May 5, 2023
eb77a02
clean
May 22, 2023
cd3c491
clean
May 22, 2023
ae06333
Merge branch 'develop' of https://github.com/Dolibarr/dolibarr into N…
May 22, 2023
c2a0196
Update onlineSign.php
BB2A-Anthony May 22, 2023
0a6eae0
Merge branch 'develop' of https://github.com/Dolibarr/dolibarr into N…
May 26, 2023
56987e3
Update 17.0.0-18.0.0.sql
BB2A-Anthony May 31, 2023
6ad69da
Update llx_propal.sql
BB2A-Anthony May 31, 2023
3f1f545
Merge branch 'develop' of https://github.com/Dolibarr/dolibarr into N…
Jul 12, 2023
6d612f1
No V18 V19
Oct 13, 2023
847daf4
clean
Oct 13, 2023
df9aa37
Merge branch develop
Oct 13, 2023
b7adf13
Merge branch develop
Dec 1, 2023
18a1c36
180->19
Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions htdocs/install/mysql/migration/17.0.0-18.0.0.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ ALTER TABLE llx_bank_account ADD COLUMN owner_country_id integer DEFAULT NULL;

ALTER TABLE llx_prelevement_bons ADD COLUMN fk_bank_account integer DEFAULT NULL;

ALTER TABLE llx_propal ADD COLUMN model_pdf_pos_sign VARCHAR(10) DEFAULT NULL AFTER last_main_doc;
Copy link
Member

@eldy eldy May 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide an example of value you plan to store in this field ?
My understanding is that field is dedicated to store position and page of the signature. If right the size of varchar 10 seems too small.

Copy link
Contributor Author

@BB2A-Anthony BB2A-Anthony May 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eldy

It's value 25:10:15:30

#24044 PR for Increment to propal

if you wish, I am willing to do it for the other signatures online when the one if validated

posX:posY:Height:Width

Copy link
Member

@eldy eldy May 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So varchar(10) seems to small. May be a varchar(32) is more ready for such feature and future enhancement?

Copy link
Contributor Author

@BB2A-Anthony BB2A-Anthony May 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eldy ok for me i changed



ALTER TABLE llx_supplier_proposal ADD UNIQUE INDEX uk_supplier_proposal_ref (ref, entity);

ALTER TABLE llx_supplier_proposal ADD INDEX idx_supplier_proposal_fk_soc (fk_soc);
Expand Down
3 changes: 2 additions & 1 deletion htdocs/install/mysql/tables/llx_propal.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ create table llx_propal

model_pdf varchar(255), -- last template used to generate main document
last_main_doc varchar(255), -- relative filepath+filename of last main generated document

model_pdf_pos_sign varchar(10),

date_livraison date DEFAULT NULL, -- delivery date
fk_shipping_method integer, -- shipping method id
fk_warehouse integer DEFAULT NULL, -- warehouse id
Expand Down