NEW : allow stock management by product #30230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change into language file htdocs/langs/fr_FR/products.lang is not allowed (only en_US is allowed for language files) |
eldy
reviewed
Jul 3, 2024
htdocs/expedition/card.php
Outdated
| } | ||
|
|
||
| if ($p->stockable_product == Product::DISABLED_STOCK) { | ||
| $w = new Entrepot($db); |
There was a problem hiding this comment.
If product is not stockable, we have no reason to manage some warehouses.
The "passing test" should be move by changing the test that is blocking later to take into account product status.
eldy
reviewed
Jul 3, 2024
htdocs/expedition/card.php
Outdated
| $w_Id = array_keys($Tw); | ||
| $stockLine[$i][$j]['qty'] = GETPOST($qty, 'int'); | ||
|
|
||
| // lorsque que l'on a le stock désactivé sur un produit/service |
eldy
reviewed
Jul 3, 2024
| /** | ||
| * 0=This service or product is not managed in stock, 1=This service or product is managed in stock | ||
| * | ||
| * @var boolean |
eldy
reviewed
Jul 3, 2024
| * | ||
| * @var boolean | ||
| */ | ||
| public $stockable_product = true; |
eldy
added
the
PR to fix - See feedback in comments
…w to create expedition lines without stock management.
|
@eldy I guess all threads can be resolved, and the checks pass. Can you have another look at this PR ? Thanks 👍 |
|
closing and restarting from branch Develop since file expedition.class.php has been split and there is no easy way to resolve conflicts. see #30996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW : allow stock management by product
When using product stocks, users may want to have some products for which they don't want to manage stocks, for example in case of subcontracting.
This PR:
Discussion started on #26184 and #26200
SQL Part : #26190