Qual: Backport phan to 18.0 #30613
Closed
Qual: Backport phan to 18.0 #30613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeweerd
force-pushed
the
backport/phan/18
branch
3 times, most recently
from
4bee1c3 to
9fc9b9c
Compare
mdeweerd
force-pushed
the
backport/phan/18
branch
from
9fc9b9c to
1bbccce
Compare
mdeweerd
force-pushed
the
backport/phan/18
branch
2 times, most recently
from
6b17e98 to
94ead13
Compare
mdeweerd
force-pushed
the
backport/phan/18
branch
5 times, most recently
from
eb97846 to
9d62db5
Compare
./.github/workflows/gh-travis.yml is included and inactive, but it must exist for ci.yml. To keep ci.yml the same accross versions, gh-travis.yml is included.
mdeweerd
force-pushed
the
backport/phan/18
branch
from
9d62db5 to
c2cbdfc
Compare
|
I think that the outcome of travis is some hazard (no code change in the tests or htdocs). There's been some trouble with travis I believe these last few days. |
|
Old versions are versions already released and open for bug fix and only bug fix maintenance, as we must reduce as much as possible the printing of any change on maintenance versions. So code quality on already released version is not necessary so we can be more focused on develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qual: Backport phan to 18.0
This PR backports phan to 18.0.
It must be merge after the backport for 19.0, which is after a "backport" to 20.0 and an "empty" PR to develop which needs to be integrated first.
By following that order, the upward path (from 18.0 to 19.0 to 20.0 to develop) should be flawless, without any merge issues for the changes related to phan.
However, do not make a squash merge to make sure the history is understood by git.