WAIT : FIX : v20 pdf space lost with images eratosthene #31298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#31268) * Use <= 0 instead of ! because delete method returns -1 or 1 * Added contact * Removed user from parameters
…arr#31285) * Fix: Number of decimals for stock values ignores configuration In the select filed for adding a new line for a proposal/invoice/... product as a line, the stock level is always printed with exactly two decimals. The number of decimals should be controlled by the existing global variable MAIN_MAX_DECIMALS_STOCK, but it is not taken into account: Building the stock level with the function price from the function price2num, which uses the configured number of decimals always lead to exactly two decimals. * Fixed patch according to suggestion.
|
This seems to fix for some case but generate trouble on other. Do yo understand what i mean. Did you test this particular case ? |
eldy
added
the
Discussion
Dolibarr#31281) * Update functions_fi.lib.php Fix calculation from some base numbers * Update functions_fi.lib.php
…libarr#31266) * Fix dol get action buttion url autocomplette * change mailto * change mailto * Remove anonymous function * Remove anonymous function * Update functions.lib.php --------- Co-authored-by: Laurent Destailleur <eldy@destailleur.fr>
…v20_pdf_space_lost_with_images_eratosthene
thersane-john
changed the title
|
I close this one i will open a new PR based on #31273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need PR #31273 to be merged before
FIX pdf space lost with images on eratosthene PDF
like #31273