FIX Asset Module Update to use gmt (versus tz) everywhere to avoid time/calculation issues #32308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX Asset Module issue as already discussed longely in this closed PR:
#31434
card.php and /class/assetdepreciationoptions.class.php
This fix is to avoid issue when using asset starting date that equal to either first or last day of fiscal year.
The solution is to get all the asset module using GMT (versus TZ) everywhere to avoid creating a new function to reset time as the following:
/**
*/
private function resetTimeToMidnight($date)
{
if (!empty($date)) {
// Assuming $date is a timestamp or string in format compatible with strtotime
return dol_mktime(0, 0, 0, dol_print_date($date, '%m'), dol_print_date($date, '%d'), dol_print_date($date, '%Y'),'gmt');
}
return $date; // Return unchanged if date is empty or null
}