Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : Removed display of login input field when main_authentication == "googleoauth" #32415

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Gouttfi
Copy link
Contributor

@Gouttfi Gouttfi commented Dec 18, 2024

FIX : Removed display of login input field when main_authentication == "googleoauth"

When the user edit htdocs/conf/conf.php and set variable $dolibarr_main_authentication to googleoauth, all fields relative to login/password, forgotten password and login button should disapear, but actually, the username field remain visible and alone
image

This commit fix this behavior and hide the username field with the other fields relative to default Dolibarr authentication system, only if $dolibarr_main_authentication == 'googleoauth'

@hregis
Copy link
Contributor

hregis commented Dec 18, 2024

@Gouttfi @eldy Dolibarr can use different method of authentication !

eg $dolibarr_main_authentication='googleoauth,ldap,dolibarr';

Maybe use a constant instead ?

@eldy eldy merged commit 7ddd25b into Dolibarr:develop Dec 19, 2024
1 of 3 checks passed
@eldy
Copy link
Member

eldy commented Dec 19, 2024

@Gouttfi @eldy Dolibarr can use different method of authentication !

eg $dolibarr_main_authentication='googleoauth,ldap,dolibarr';

Maybe use a constant instead ?

@hregis this should not be a problem the test is on == "googleoauth", so hide the login only when using only oauth. When we use other method, the field remains visible. What we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants