fix: allow list mass action update price when price mode is multiprice price #32724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
added
the
PR to fix - Conflict or CI error to solve
FHenry
removed
the
PR to fix - Conflict or CI error to solve
eldy
reviewed
Jan 23, 2025
| @@ -829,9 +829,8 @@ | |||
| //'presend'=>img_picto('', 'email', 'class="pictofixedwidth"').$langs->trans("SendByMail"), | |||
| ); | |||
| if ($user->hasRight($rightskey, 'creer')) { | |||
| if (getDolGlobalString('PRODUCT_PRICE_UNIQ') || getDolGlobalString('PRODUIT_CUSTOMER_PRICES')) { | |||
There was a problem hiding this comment.
It seems there is other cases.
When in dev mode, we see 6 different values in combo for parameter to set the for rules to define price.
The update price was implemented for 2, to if you remove this test, it means you implement it for the 6 cases now, so 4 more cases.
However in htdocs/core/actions_massactions.inc.php, i see you add only one if for case PRODUIT_MULTIPRICES
The initial fix was a protection to avoid bad effect on not yet implement cases, removing it to support more case would be better in develop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the contrary of #32564 a better solution is to update all multiprice (and display inforamtion message).
As this feature was present, the old fix to avoid it was not ideal. Thie PR allow the feature again in this case and do the correct update.