Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Promise.all and friends #678

Open
2 tasks
Domiii opened this issue Feb 20, 2022 · 0 comments
Open
2 tasks

Fix Promise.all and friends #678

Domiii opened this issue Feb 20, 2022 · 0 comments
Assignees
@Domiii
Labels
async bug Something isn't working instrumentation Related to how we instrument the code in `dbux-babel-plugin`

Comments

@Domiii
Copy link
Owner

Domiii commented Feb 20, 2022 •
edited
Loading

  • Fix Promise.all and friends: CGRs of "dangling" promises should not be chained to Promise.all/race/any etc.
    • Example of a symptom of trying to CHAIN dangling promise nodes in sequelize -> findOrCreate-parallel:
  • test, e.g. with:
    • __samplesInput__/async/sync4-promise-all.js
    • Promise.all2-fail1.js sample
@Domiii Domiii added bug Something isn't working instrumentation Related to how we instrument the code in `dbux-babel-plugin` labels Feb 20, 2022
@Domiii Domiii self-assigned this Feb 20, 2022
@Domiii Domiii changed the title Fix Promise.all and friends Fix Promise.all and friends Feb 20, 2022
@Domiii Domiii mentioned this issue Feb 23, 2022
Open
59 tasks
@Domiii Domiii added the async label Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Domiii Domiii

Labels
async bug Something isn't working instrumentation Related to how we instrument the code in `dbux-babel-plugin`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Domiii