Add check for when no port is specified for job or healthcheck and fi…

…x integration test

pkg/biscepter/job.go

@@ -72,6 +72,10 @@ func GetJobFromConfig(r io.Reader) (*Job, error) {
 		job.Ports = []int{config.Port}
 	}
 
+	if len(job.Ports) == 0 {
+		return nil, fmt.Errorf("no port specified for job")
+	}
+
 	// Set all the healthchecks
 	checkTypes := map[string]HealthcheckType{
 		"http":   HttpGet200,
@@ -86,6 +90,10 @@ func GetJobFromConfig(r io.Reader) (*Job, error) {
 			return nil, fmt.Errorf("invalid check type supplied for healthcheck %s", check.Type)
 		}
 
+		if check.Port == 0 {
+			return nil, fmt.Errorf("no port specified for healthcheck %#v", check)
+		}
+
 		job.Healthchecks = append(job.Healthchecks, Healthcheck{
 			Port:      check.Port,
 			CheckType: checkType,

pkg/biscepter/job_integration_test.go

@@ -283,7 +283,7 @@ func TestRunCommitByOffset(t *testing.T) {
 		Ports: []int{3333},
 
 		Healthchecks: []biscepter.Healthcheck{
-			{CheckType: biscepter.Script, Data: "true", Config: biscepter.HealthcheckConfig{Retries: 50, Backoff: 10 * time.Millisecond, MaxBackoff: 10 * time.Millisecond}},
+			{CheckType: biscepter.Script, Port: 3333, Data: "true", Config: biscepter.HealthcheckConfig{Retries: 50, Backoff: 10 * time.Millisecond, MaxBackoff: 10 * time.Millisecond}},
 		},
 
 		CommitReplacementsBackup: "/dev/null",