fix: fix notification types

DouyinFE · Dec 25, 2023 · 016e8f4 · 016e8f4
1 parent 71322e8
commit 016e8f4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/semi-foundation/notification/notificationFoundation.ts b/packages/semi-foundation/notification/notificationFoundation.ts
@@ -10,16 +10,16 @@ export type NoticeTheme = 'light' | 'normal';
 
 export interface NoticeProps {
     duration?: number;
-    id?: string | number;
+    id?: string;
     title?: any;
     content?: any;
     position?: NoticePosition;
     type?: NoticeType;
     onClick?: (e: any) => void;
     onClose?: () => void;
-    onCloseClick?: (id: string | number) => void;
+    onCloseClick?: (id: string) => void;
     showClose?: boolean;
-    close?: (id: string | number) => void;
+    close?: (id: string) => void;
     zIndex?: number;
     icon?: any;
     getPopupContainer?: () => HTMLElement;

diff --git a/packages/semi-ui/notification/index.tsx b/packages/semi-ui/notification/index.tsx
@@ -193,13 +193,13 @@ class NotificationList extends BaseComponent<NotificationListProps, Notification
 
     has = (id: string) => this.foundation.has(id);
 
-    remove = (id: string | number) => {
+    remove = (id: string) => {
         this.foundation.removeNotice(String(id));
     };
 
 
 
-    update = (id: string|number, opts: NoticeProps)=>{
+    update = (id: string, opts: NoticeProps)=>{
         return this.foundation.update(id, opts);
     }
 

diff --git a/packages/semi-ui/notification/notice.tsx b/packages/semi-ui/notification/notice.tsx
@@ -33,7 +33,7 @@ class Notice extends BaseComponent<NoticeReactProps, NoticeState> {
     static contextType = ConfigContext;
     static propTypes = {
         duration: PropTypes.number,
-        id: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+        id: PropTypes.string,
         title: PropTypes.node,
         content: PropTypes.node, // strings、numbers、array、element
         type: PropTypes.oneOf(types),