Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat slider label tooltip #1934

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Feat slider label tooltip #1934

merged 2 commits into from
Nov 27, 2023

Conversation

DaiQiangReal
Copy link
Collaborator

@DaiQiangReal DaiQiangReal commented Nov 27, 2023

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Feat: Slider 新增 showMarkLabel 控制 label 显隐, tooltipOnMark 在 mark 上显示 tooltip,showArrow 控制 tooltip 的三角形显隐

🇺🇸 English

  • Feat: Slider adds showMarkLabel to control the visibility of the label, tooltipOnMark to display the tooltip on the mark, and showArrow to control the visibility of the tooltip triangle.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Nov 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11a97bb:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@DaiQiangReal DaiQiangReal force-pushed the feat_slider_label_tooltip branch from e80396f to 0241bbb Compare November 27, 2023 08:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6cfb424) 88.08% compared to head (4cc81b8) 88.09%.

❗ Current head 4cc81b8 differs from pull request most recent head 11a97bb. Consider uploading reports for the commit 11a97bb to get more accurate results

Files Patch % Lines
packages/semi-ui/slider/index.tsx 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1934      +/-   ##
===========================================
+ Coverage    88.08%   88.09%   +0.01%     
===========================================
  Files          436      436              
  Lines        25580    25583       +3     
  Branches      6452     6453       +1     
===========================================
+ Hits         22531    22537       +6     
+ Misses        3049     3046       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pointhalo pointhalo merged commit 4ecf544 into release Nov 27, 2023
6 checks passed
@pointhalo pointhalo deleted the feat_slider_label_tooltip branch November 27, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants