fix: fixed the problem that after selecting a radio option, clicking outside does not trigger the onblur event #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outside does not trigger the onblur event
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 683789c:
|
Passing run #2117 ↗︎
Details:
Review all test suite changes for PR #1977 ↗︎ |
||||||||||||||||||||
YyumeiZhang
approved these changes
Dec 15, 2023
pointhalo
reviewed
Dec 26, 2023
| @@ -363,6 +363,7 @@ export default class SelectFoundation extends BaseFoundation<SelectAdapter> { | |||
| this.close(e); | |||
| this._notifyBlur(e); | |||
| this._adapter.updateFocusState(false); | |||
| this._adapter.unregisterClickOutsideHandler(); | |||
There was a problem hiding this comment.
不能将 unregister 的操作跟空白点击绑定在一起。
假设用户是点击后打开 Select LOptionList，但是又通过 ref.close() 方式手动关闭了 select，此时是不存在触发 clickOutSide 逻辑的。 这个监听就会一直残留。但实际上 select 已经收起了，有残留监听是不合理的。
YannLynn
added a commit
that referenced
this pull request
Dec 26, 2023
15 tasks
pointhalo
pushed a commit
that referenced
this pull request
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文模板 / Chinese Template
What kind of change does this PR introduce? (check at least one)
PR description
Fixes #
Changelog
🇨🇳 Chinese
🇺🇸 English
Checklist
Other
Additional information