Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the new version of pr #1977 #1996

Merged
merged 1 commit into from
Dec 26, 2023
Merged

fix: the new version of pr #1977 #1996

merged 1 commit into from
Dec 26, 2023

Conversation

YannLynn
Copy link
Collaborator

@YannLynn YannLynn commented Dec 26, 2023

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #1992

PR #1977 的修改会导致 issue #1992 的问题。复盘后总结认为 PR #1977 的修改不合理。

所以本 PR 主要做两件事情:

  1. 放弃 PR #1977 的修改
  2. 通过另一种方式解决 PR #1977 想要解决的问题(单选选择后点击外部区域不触发 onBlur 事件)

Changelog

🇨🇳 Chinese

  • Fix: 修复 Select 在单选情况下,点击外部后再次选择选项失败问题(影响范围 v2.49.0)

🇺🇸 English

  • Fix: fix the problem of Select failing to select option after clicking outside when the selection is radio (scope of impact v2.49.0)

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@YannLynn YannLynn requested a review from pointhalo December 26, 2023 11:53
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff27463:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

Copy link

cypress bot commented Dec 26, 2023

Passing run #2138 ↗︎

0 237 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge ff27463 into 2559649...
Project: semi-design Commit: 59b435f67c ℹ️
Status: Passed Duration: 09:58 💡
Started: Dec 26, 2023 12:02 PM Ended: Dec 26, 2023 12:12 PM

Review all test suite changes for PR #1996 ↗︎

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2559649) 88.30% compared to head (59b435f) 88.28%.

❗ Current head 59b435f differs from pull request most recent head ff27463. Consider uploading reports for the commit ff27463 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1996      +/-   ##
==========================================
- Coverage   88.30%   88.28%   -0.02%     
==========================================
  Files         436      436              
  Lines       25626    25627       +1     
  Branches     6484     6484              
==========================================
- Hits        22629    22626       -3     
- Misses       2997     3001       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pointhalo pointhalo merged commit fc972f9 into main Dec 26, 2023
10 checks passed
@pointhalo pointhalo deleted the fix-1992-new branch December 26, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select ] 单选受控,点击外部空白区域失去焦点后,再次点击选项无法选上
3 participants