Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix multiple dropdown click mouse event with level judge #2003

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

DaiQiangReal
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复 Dropdown 点击子菜单事件 onClick 函数执行时机过早的问题,可能导致用户在 onClick 函数内无法 Focus Dropdown 外部元素并触发外部元素的 Blur,影响范围,2.43.0-beta.0 ~ 2.50.0-beta.0。

🇺🇸 English

  • Fix: Fixed the problem that the onClick function of the Dropdown click submenu event is executed too early, which may cause the user to be unable to focus on the Dropdown external element and trigger the Blur of the external element within the onClick function. The scope of impact is 2.43.0-beta.0 ~ 2.50.0-beta .0.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Dec 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b0c269f:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

Copy link

cypress bot commented Dec 28, 2023

Passing run #2205 ↗︎

0 218 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge b0c269f into 0526e39...
Project: semi-design Commit: b84167dd2a ℹ️
Status: Passed Duration: 08:05 💡
Started: Jan 23, 2024 9:22 AM Ended: Jan 23, 2024 9:31 AM

Review all test suite changes for PR #2003 ↗︎

@codecov-commenter
Copy link

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (d40aee6) 88.26% compared to head (b84167d) 87.39%.
Report is 57 commits behind head on release.

❗ Current head b84167d differs from pull request most recent head b0c269f. Consider uploading reports for the commit b0c269f to get more accurate results

Files Patch % Lines
...ckages/semi-foundation/input/textareaFoundation.ts 61.90% 8 Missing ⚠️
packages/semi-ui/image/previewInner.tsx 53.84% 6 Missing ⚠️
packages/semi-ui/input/textarea.tsx 80.95% 4 Missing ⚠️
packages/semi-foundation/cascader/util.ts 81.81% 2 Missing ⚠️
packages/semi-ui/dropdown/dropdownItem.tsx 60.00% 2 Missing ⚠️
...es/semi-foundation/image/previewInnerFoundation.ts 80.00% 1 Missing ⚠️
packages/semi-ui/image/previewFooter.tsx 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #2003      +/-   ##
===========================================
- Coverage    88.26%   87.39%   -0.88%     
===========================================
  Files          437      437              
  Lines        25646    25655       +9     
  Branches      6488     6501      +13     
===========================================
- Hits         22637    22420     -217     
- Misses        3009     3235     +226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaiQiangReal DaiQiangReal merged commit 704c597 into release Jan 23, 2024
9 checks passed
@DaiQiangReal DaiQiangReal deleted the fix_dropdown_useLevelJudge branch January 23, 2024 09:33
DaiQiangReal added a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants