Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed when a TextArea with maxLength is input in Chinese, clicki… #2019

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Jan 10, 2024

…ng outside triggers blur, and the echoed content does not comply with the maxLength setting

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2005

问题细节见 issue 的 comment

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

…ng outside triggers blur, and the echoed content does not comply with the maxLength setting
Copy link

codesandbox-ci bot commented Jan 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11c6dda:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

Copy link

cypress bot commented Jan 10, 2024

Passing run #2175 ↗︎

0 238 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 11c6dda into 7837643...
Project: semi-design Commit: eddbde10f8 ℹ️
Status: Passed Duration: 10:38 💡
Started: Jan 10, 2024 11:14 AM Ended: Jan 10, 2024 11:24 AM

Review all test suite changes for PR #2019 ↗︎

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7837643) 88.22% compared to head (eddbde1) 88.22%.

❗ Current head eddbde1 differs from pull request most recent head 11c6dda. Consider uploading reports for the commit 11c6dda to get more accurate results

Files Patch % Lines
...ckages/semi-foundation/input/textareaFoundation.ts 60.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2019      +/-   ##
==========================================
- Coverage   88.22%   88.22%   -0.01%     
==========================================
  Files         437      437              
  Lines       25646    25658      +12     
  Branches     6497     6502       +5     
==========================================
+ Hits        22627    22637      +10     
- Misses       3019     3021       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YyumeiZhang YyumeiZhang merged commit eaf59fe into main Jan 12, 2024
9 checks passed
@YyumeiZhang YyumeiZhang deleted the fix/textarea-maxlength branch January 12, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants