Feat/modal content class #2162
Merged
Feat/modal content class #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Fix Typo single-line css omission accuracy issue DouyinFE#1731
* fix: optimize code logic in Cascader * fix: optimize code logic in Cascader for undefined value
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d08105:
|
|
预计跟 v2.57 beta.0 版本处理 |
我的pr会在2.57上线吗👀 |
| @@ -286,6 +286,7 @@ export default class ModalContent extends BaseComponent<ModalContentReactProps, | |||
| onAnimationEnd={props.onAnimationEnd} | |||
| className={cls([`${cssClasses.DIALOG}-content`, | |||
| props.contentClassName, | |||
There was a problem hiding this comment.
为什么要给 ModalContent 新增一个 modalContentClassName，可以合并到 contentClassName 里吗
added 2 commits
April 19, 2024 15:59
|
这个很好 因为现在modal样式基本都是这个content里，而默认提供的那个contentClassName竟然附的是body里... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the modalContentClass property of the Modal component, which can be used to set the style class name of Modal content