Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload addOnPasting switch to false should not trigger process #2176

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

pointhalo
Copy link
Collaborator

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Changelog

🇨🇳 Chinese

  • Fix: 修复 Upload 将 addOnPasting 切换为 false 后,粘贴上传依然触发的问题

🇺🇸 English

  • Fix: Fixed the problem that after Upload switches addOnPasting to false, paste upload is still triggered.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@pointhalo pointhalo requested a review from DaiQiangReal April 17, 2024 09:37
Copy link

codesandbox-ci bot commented Apr 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1cd77c6:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Apr 17, 2024

Passing run #2431 ↗︎

0 252 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 1cd77c6 into c2d893b...
Project: semi-design Commit: f325125b20 ℹ️
Status: Passed Duration: 10:29 💡
Started: Apr 18, 2024 3:01 AM Ended: Apr 18, 2024 3:12 AM

Review all test suite changes for PR #2176 ↗︎

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 88.16%. Comparing base (2fb5238) to head (f325125).
Report is 7 commits behind head on main.

❗ Current head f325125 differs from pull request most recent head 1cd77c6. Consider uploading reports for the commit 1cd77c6 to get more accurate results

Files Patch % Lines
packages/semi-foundation/upload/foundation.ts 8.33% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
- Coverage   88.20%   88.16%   -0.04%     
==========================================
  Files         440      440              
  Lines       26000    26000              
  Branches     6631     6632       +1     
==========================================
- Hits        22934    22924      -10     
- Misses       3066     3076      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pointhalo pointhalo merged commit 599c348 into main Apr 19, 2024
9 checks passed
@pointhalo pointhalo deleted the fix-uploadAddonPastingSwitchToFalse branch April 19, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants