Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed Table text-align bug in RTL mode #2172 #2214

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

shijiatongxue
Copy link
Collaborator

@shijiatongxue shijiatongxue commented Apr 30, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix

PR description

Fixes #2172,搭配 storybook 查看效果 http://localhost:6006/?path=/story/table--column-align-with-sorter

问题原因:带排序和筛选的区域,justify-content 需要根据 rtl 做调整

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 536dbdd:

Sandbox Source
pr-story Configuration

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (6033634) to head (79c92f1).

❗ Current head 79c92f1 differs from pull request most recent head 536dbdd. Consider uploading reports for the commit 536dbdd to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
+ Coverage   88.23%   88.24%   +0.01%     
==========================================
  Files         440      440              
  Lines       26029    26029              
  Branches     6640     6640              
==========================================
+ Hits        22966    22969       +3     
+ Misses       3063     3060       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 30, 2024

Passing run #2471 ↗︎

0 258 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 536dbdd into 6033634...
Project: semi-design Commit: 79c92f140b ℹ️
Status: Passed Duration: 10:43 💡
Started: Apr 30, 2024 5:08 AM Ended: Apr 30, 2024 5:19 AM

Review all test suite changes for PR #2214 ↗︎

@pointhalo pointhalo merged commit 74998fd into main May 6, 2024
11 checks passed
@pointhalo pointhalo deleted the fix/2172 branch May 6, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <Table> text-align bug in RTL mode
4 participants