Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed DatePicker selected status bug when double click #1652 #2389

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

shijiatongxue
Copy link
Collaborator

@shijiatongxue shijiatongxue commented Jul 31, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #1652

错误原因:selected Set 中保存了非 string 的值(Date),获取 selected 状态时,通过 set.has(<string>) 判断错误。

Changelog

🇨🇳 Chinese

  • Fix: 修复 DatePicker 点击选择的日期两次后,选中态颜色丢失

🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

codesandbox-ci bot commented Jul 31, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1b7f535:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Jul 31, 2024



Test summary

268 0 11 0


Run details

Project semi-design
Status Passed
Commit cc41aa2 ℹ️
Started Aug 20, 2024 11:24 AM
Ended Aug 20, 2024 11:34 AM
Duration 10:03 💡
OS Linux Debian -
Browser Chrome 103

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@pointhalo pointhalo merged commit 295b8ff into main Aug 20, 2024
9 checks passed
@pointhalo pointhalo deleted the fix/1652 branch August 20, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DatePicker needConfirm 情况下,点击选择的日期两次后,选中态颜色丢失
3 participants