lab2 #897
Open
lab2 #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Рыбкина Анастасия Алексеевна Группа 3091
|
Не собирается. |
|
Всё ещё не собирается. |
|
Теперь не проходит тест. |
|
Всё ещё не проходит. |
Dovgalyuk
requested changes
Sep 24, 2024
Lab2CPP/lab2.cpp
Outdated
| } | ||
|
|
||
| if (!stack_empty(operators)) { | ||
| if (stack_empty(operators)) { |
There was a problem hiding this comment.
Как здесь может сработать empty?
|
|
||
| else if (example[i] == ')') { | ||
| while (!stack_empty(operators) && stack_get(operators) != '(') { | ||
| if (stack_empty(values)) throw std::runtime_error("Invalid expression"); |
There was a problem hiding this comment.
Тут empty никогда не сработает.
LibraryCPP/stack.h
Outdated
| struct Stack; | ||
| typedef struct Stack { | ||
| Vector* vector; | ||
| } Stack; |
There was a problem hiding this comment.
В заголовочный файл выносить определение структуры не нужно.
Dovgalyuk
requested changes
Sep 25, 2024
| stack_pop(values); | ||
|
|
||
| int val1 = stack_get(values); | ||
| stack_pop(values); |
There was a problem hiding this comment.
Нужная проверка на пустоту тоже пропала вместе с ненужной.
LibraryCPP/vector.h
Outdated
| // Vector (dynamic array) | ||
| // Stores integer values inside | ||
| typedef int Data; | ||
|
|
||
| struct Vector; | ||
| struct Vector { |
There was a problem hiding this comment.
Этого не должно быть в заголовочном файле.
|
Определение вектора размножилось. И ненужные проверки появились. |
|
Несколько лишних проверок, о которых я раньше говорил, осталось. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.