Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab2 #922

Open
wants to merge 71 commits into
base: master
Choose a base branch
from
Open

Lab2 #922

wants to merge 71 commits into from

Conversation

tolstosup
Copy link

No description provided.

@tolstosup tolstosup closed this Sep 23, 2024
@tolstosup tolstosup reopened this Sep 23, 2024
@Dovgalyuk
Copy link
Owner

Нужен ещё тест для самой задачи.

Lab2CPP/lab2.cpp Outdated

std::string temp = "", check = "";
in >> temp;
in >> check;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Программа-решение не должна сама это проверять, она только выводит ответ.

Lab2CPP/lab2.cpp Outdated
std::cout << "Test1. Incorrect answer!" << std::endl;
}

in >> temp;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше добавить два теста.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не исправлено.

return (Data)0;
}

ListItem *list_item_next(ListItem *item)
{
return NULL;
if(item != nullptr && item->next != nullptr)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вторая проверка ничего не даёт.

LibraryCPP/list.cpp Show resolved Hide resolved
return NULL;
if (list != nullptr && item != nullptr && item->next != nullptr)
{
item->next->next->prev = item;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item->next->next не проверяется

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не исправлено.

@@ -1,6 +1,6 @@
#ifndef STACK_H
#define STACK_H

#include "list.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь не надо его подключать.

Lab2CPP/lab2.cpp Outdated
std::cout << "Test1. Incorrect answer!" << std::endl;
}

in >> temp;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не исправлено.


if(item->next != nullptr)
newEl->next = item->next;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

item->next->prev не меняется

return NULL;
if (list != nullptr && item != nullptr && item->next != nullptr)
{
item->next->next->prev = item;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не исправлено.

@Dovgalyuk
Copy link
Owner

Не все замечания исправлены.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants