-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lab2 #922
base: master
Are you sure you want to change the base?
Lab2 #922
Conversation
Нужен ещё тест для самой задачи. |
Lab2CPP/lab2.cpp
Outdated
|
||
std::string temp = "", check = ""; | ||
in >> temp; | ||
in >> check; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Программа-решение не должна сама это проверять, она только выводит ответ.
Lab2CPP/lab2.cpp
Outdated
std::cout << "Test1. Incorrect answer!" << std::endl; | ||
} | ||
|
||
in >> temp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Лучше добавить два теста.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не исправлено.
LibraryCPP/list.cpp
Outdated
return (Data)0; | ||
} | ||
|
||
ListItem *list_item_next(ListItem *item) | ||
{ | ||
return NULL; | ||
if(item != nullptr && item->next != nullptr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вторая проверка ничего не даёт.
LibraryCPP/list.cpp
Outdated
return NULL; | ||
if (list != nullptr && item != nullptr && item->next != nullptr) | ||
{ | ||
item->next->next->prev = item; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
item->next->next не проверяется
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не исправлено.
LibraryCPP/stack.h
Outdated
@@ -1,6 +1,6 @@ | |||
#ifndef STACK_H | |||
#define STACK_H | |||
|
|||
#include "list.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Здесь не надо его подключать.
Lab2CPP/lab2.cpp
Outdated
std::cout << "Test1. Incorrect answer!" << std::endl; | ||
} | ||
|
||
in >> temp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не исправлено.
|
||
if(item->next != nullptr) | ||
newEl->next = item->next; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
item->next->prev не меняется
LibraryCPP/list.cpp
Outdated
return NULL; | ||
if (list != nullptr && item != nullptr && item->next != nullptr) | ||
{ | ||
item->next->next->prev = item; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не исправлено.
Не все замечания исправлены. |
No description provided.